Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement DoubleEndedIterator for FilterOk #947

Closed
Xenira opened this issue May 27, 2024 · 3 comments
Closed

Implement DoubleEndedIterator for FilterOk #947

Xenira opened this issue May 27, 2024 · 3 comments

Comments

@Xenira
Copy link
Contributor

Xenira commented May 27, 2024

Should be doable with rfind unless there is a reason I overlooked.

Would be willing to implement this.
@Philippe-Cholet
Copy link
Member

Philippe-Cholet commented May 27, 2024 •
edited

FlattenOk, MapSpecialCase (for MapOk, MapInto) are double ended and ProcessResults since a few weeks.
FilterOk and FilterMapOk are not (yet) but it seems reasonable to me.

Specialization tests and benchmarks will need to be updated but that's simple to do.

Xenira added a commit to Xenira/itertools that referenced this issue May 27, 2024
@Xenira
feat(FilterOk): implement DoubleEndedIterator
f555d16 
Refs: rust-itertools#947
@Xenira Xenira mentioned this issue May 27, 2024
Merged
@Xenira
Copy link
Contributor Author

Xenira commented May 27, 2024 •
edited

Like that? Have to admit, not entirely comprehending the test system yet.

Also not sure, if rfold needs custom impl. FlattenOk didn't have any. Edit: nvm, found it. So prob. yes.

Xenira added a commit to Xenira/itertools that referenced this issue May 27, 2024
@Xenira
feat(FilterOk): implement DoubleEndedIterator
d882491 
Refs: rust-itertools#947
github-merge-queue bot pushed a commit that referenced this issue May 27, 2024
@Xenira @phimuemue
feat(FilterOk): implement DoubleEndedIterator
23bf81a 
Refs: #947
Xenira added a commit to Xenira/itertools that referenced this issue May 27, 2024
@Xenira
feat(FilterMapOk): implement DoubleEndedIterator
dd1a88a 
Refs: rust-itertools#947
@Xenira Xenira mentioned this issue May 27, 2024
Merged
github-merge-queue bot pushed a commit that referenced this issue May 27, 2024
@Xenira @Philippe-Cholet
feat(FilterMapOk): implement DoubleEndedIterator
ad5cc96 
Refs: #947
@Philippe-Cholet
Copy link
Member

Philippe-Cholet commented May 27, 2024 •
edited

@Xenira I did not notice before they were not double ended so thanks for this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Xenira @Philippe-Cholet