Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update rust/itertools versions in the doc #738

Merged
merged 1 commit into from
Aug 26, 2023
Merged

Update rust/itertools versions in the doc #738

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,8 +42,8 @@
//!
//! ## Rust Version
//!
//! This version of itertools requires Rust 1.32 or later.
#![doc(html_root_url="https://docs.rs/itertools/0.8/")]
//! This version of itertools requires Rust 1.36 or later.
#![doc(html_root_url="https://docs.rs/itertools/0.11/")]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder why we have this line at all. I've never written this in any of my other crates. Perhaps it's just a vestige of the past that can be removed without issue?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well I did not consider that but it seems so. And in my search I found rust-cli/env_logger#185 helpful. Basically I think it's okay to remove it.

But we still will have to update the MSRV here in the future, unless we expect people to look at the Cargo.toml in which case we should remove that part too.


#[cfg(not(feature = "use_std"))]
extern crate core as std;
Expand Down