Skip to content

Commit

Permalink
Auto merge of rust-lang#123030 - GuillaumeGomez:rustdoc-sysroot-out-o…
Browse files Browse the repository at this point in the history
…f-arg-file, r=notriddle

Move `--sysroot` argument out of the argument file to fix miri issue

Fixes rust-lang/miri#3404.

For now, miri needs this argument to be moved out of the arg file so they can update it if needed.

cc `@RalfJung`

r? `@notriddle`
  • Loading branch information
bors committed Mar 25, 2024
2 parents af98101 + 8c219af commit cb7c636
Showing 1 changed file with 6 additions and 3 deletions.
9 changes: 6 additions & 3 deletions src/librustdoc/doctest.rs
Expand Up @@ -67,9 +67,6 @@ pub(crate) fn generate_args_file(file_path: &Path, options: &RustdocOptions) ->
}
}

if let Some(sysroot) = &options.maybe_sysroot {
content.push(format!("--sysroot={}", sysroot.display()));
}
for lib_str in &options.lib_strs {
content.push(format!("-L{lib_str}"));
}
Expand Down Expand Up @@ -411,6 +408,10 @@ fn run_test(

compiler.arg(&format!("@{}", rustdoc_options.arg_file.display()));

if let Some(sysroot) = &rustdoc_options.maybe_sysroot {
compiler.arg(format!("--sysroot={}", sysroot.display()));
}

compiler.arg("--edition").arg(&edition.to_string());
compiler.env("UNSTABLE_RUSTDOC_TEST_PATH", path);
compiler.env("UNSTABLE_RUSTDOC_TEST_LINE", format!("{}", line as isize - line_offset as isize));
Expand Down Expand Up @@ -950,6 +951,7 @@ pub(crate) struct IndividualTestOptions {
runtool_args: Vec<String>,
target: TargetTriple,
test_id: String,
maybe_sysroot: Option<PathBuf>,
}

impl IndividualTestOptions {
Expand Down Expand Up @@ -982,6 +984,7 @@ impl IndividualTestOptions {
runtool_args: options.runtool_args.clone(),
target: options.target.clone(),
test_id,
maybe_sysroot: options.maybe_sysroot.clone(),
}
}
}
Expand Down

0 comments on commit cb7c636

Please sign in to comment.