Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo in lib.rs #144

Merged
merged 2 commits into from
Mar 21, 2019
Merged

Fix typo in lib.rs #144

merged 2 commits into from
Mar 21, 2019

Conversation

fbruetting
Copy link
Contributor

No description provided.

Copy link
Contributor

@KodrAus KodrAus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well spotted! Thanks @fbruetting.

I've just left one comment.

src/lib.rs Outdated

- `spin_no_std`: This allows using this crate in a no-std environment, by depending on the standalone `spin` crate.

Both features depend on unstable language features, which means
This feature depends on unstable language features, which means
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah actually this isn't accurate anymore. The spin_no_std feature works on the stable Rust channel now. Would you like to just remove this sentence altogether?

@fbruetting
Copy link
Contributor Author

fbruetting commented Mar 21, 2019

Of course. Should be done now (I’m not yet used to the GitHub editing). Don’t know how I can squash or rewrite the old commit here, but I think you can do.

Copy link
Contributor

@KodrAus KodrAus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me!

The build failure for Windows is unrelated.

@KodrAus KodrAus merged commit 88994b2 into rust-lang-nursery:master Mar 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants