Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tracking issue for kv_unstable (structured logging) #328

Open
KodrAus opened this issue Apr 29, 2019 · 4 comments

Comments

Projects
None yet
2 participants
@KodrAus
Copy link
Contributor

commented Apr 29, 2019

Tracking issue for the implementation of #296. See also #149

  • Initial implementation (#324)
  • Integration with frameworks and loggers:
  • Explore macro support
  • Integration with serialization frameworks:
  • Micro benchmarks
  • Documentation and examples
  • Stabilization review
  • Open questions
    • Should Source::count return a Result<usize> instead of a plain usize?

This was referenced Apr 29, 2019

tmccombs added a commit to tmccombs/env_logger that referenced this issue Jul 2, 2019

@yoshuawuyts

This comment has been minimized.

Copy link

commented Jul 2, 2019

@KodrAus thanks for all the work you've put into this (and linking to this issue from a forum post).

I was curious: is there a release planned that includes the beta version of kv? I actually wanted to use the beta for async-log, but given there wasn't any release yet it wasn't possible 😅

@KodrAus

This comment has been minimized.

Copy link
Contributor Author

commented Jul 4, 2019

Hi @yoshuawuyts! 👋

Right now any release of log we publish will include this API under the kv_unstable feature gate, but we're not ready to commit to backwards compatibility just yet. So if you depend on log from git then you can access the API:

[dependencies.log]
git = "https://github.com/rust-lang-nursery/log.git"
features = ["kv_unstable"]

I think what we need are a few draft PRs in some of these log frameworks that tease out any breaking changes we should make, and then will be able to publish a release that replaces the kv_unstable feature gate with a kv one.

@yoshuawuyts

This comment has been minimized.

Copy link

commented Jul 4, 2019

Right now any release of log we publish will include this API under the kv_unstable feature gate,

Oh oops, maybe I was being a bit vague. The last release on crates.io was done in October 2018, which means currently no releases ship with kv_unstable on crates.io. Which in turn (I believe) means we can't ship any versions to crates.io.

In order to help test this feature, it would be nice if there was a release on crates.io with the ["kv_unstable"] feature available. For experimental technology such as async-log I think we can get away with publishing a version that directly depends on this feature, and keep updating it as it's polished.

So my question is: could a version be of log be published to crates.io that includes the experimental flag?

P.S. Thanks for taking time out of your day to reply to my questions!

@KodrAus

This comment has been minimized.

Copy link
Contributor Author

commented Jul 6, 2019

In order to help test this feature, it would be nice if there was a release on crates.io with the ["kv_unstable"] feature available. For experimental technology such as async-log I think we can get away with publishing a version that directly depends on this feature, and keep updating it as it's polished.

Ah this sounds fair enough. I think we can get pretty far without needing to break anything, but it's probably going to happen at some point. But right now it is harder for folks to get started with these new APIs, so once #339 lands I'll put together a release so you can depend on it from crates.io and browse the docs on docs.rs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.