Properly handle namespaces for enum configuration options #1162
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you add a note to the unreleased section of the changelog about this breaking change? Thanks! |
|
And did it fix the issues you were seeing in that other bug? |
...by using canonical_path rather than canonical_name. Fixes #1125.
|
Added a note to the changelog. I haven't had a chance to test the other issue yet, I may get to it today (but may not). |
|
@bors-servo r+ |
|
📌 Commit 89efc23 has been approved by |
|
☀️ Test successful - status-travis |
fitzgen
reviewed
Nov 28, 2017
| rather than its "canonical name", which does not. This is a breaking change | ||
| that requires callers which target a namespaced C++ enum to call e.g. | ||
| `bitfield_enum("<namespace>::<enum_name>")` rather than e.g. | ||
| `bitfield_enum("<enum_name>")`. [#1162][] |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...by using canonical_path rather than canonical_name.
Fixes #1125.
r? @emilio