refactor(fixtures): Move to snapbox with SVGs #86
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Muscraft
force-pushed
the
use-snapbox-for-testing
branch
2 times, most recently
from
4632fe9
to
193b194
Compare
epage
reviewed
Mar 3, 2024
epage
reviewed
Mar 3, 2024
Muscraft
force-pushed
the
use-snapbox-for-testing
branch
from
193b194
to
ad80183
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was not happy with how fixtures were currently being run, as when one failed it would take down the whole thing failed, and it could not continue past the failed fixture test. To make this better I switched the fixture tests to use a custom test harness, built on top of
snapbox::harness::Harness. This makes it so each test is run by itself so you can see exactly which test is failing. In doing this I also switched the expected output to be compared to SVGs, which makes seeing visual changes much easier, while still retaining the ability to see the text differences.