Show a warning: root folder must contain cargo.toml

[Dowwie]

FYI-- unless the root project folder added to Atom contains the Cargo.toml, the RLS won't work.

I didn't have any warnings about this requirement in Atom, but did in VSCode.

[alexheretic]

That's right, I've added a note to the readme that mentions this.

Perhaps we could add a warning with some advice. Is that what you're suggesting?

[Dowwie]

Yes, exactly.

…

On Jan 27, 2018 9:11 AM, "Alex Butler" ***@***.***> wrote: That's right, I've added a note to the readme <https://github.com/mehcode/atom-ide-rust#multi-crate-projects> that mentions this. Perhaps we could add a warning with some advice. Is that what you're suggesting? — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#49 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ACexFN8MCk6NrYbYY_bPXOWWYQ-QAd-_ks5tOy6ogaJpZM4RvRKO> .

[alexheretic]

I agree, I just had a quick look and we start Rls in this case but it just doesn't work. When I get some time I'll figure out if this logic can be in Rls itself (to send an error message to clients). But perhaps a short term fix could be shoved into this package anyway.

[alexheretic]

I've proposed to fix this in Rls: rust-lang/rls#687

[alexheretic]

Rls now sends build failure notifications

It still isn't obvious that you should add a root Cargo.toml. Perhaps we should add a hint client side?

[alexheretic]

If we can resolve rust-lang/rls#723 so that ide-rust can listen to build-finished (fail/success) I'll be able to fairly easily add functionality including: On failure; scanning for Cargo.toml in parent dirs and showing a hint to add one if not found.

[alexheretic]

With rust-lang/rls#657 (ie in the next Rls release) the Rls error message has improved.

This is now good enough to point people in the right direction. Maybe in future we could add a button to auto generate an appropriate Cargo.toml. For now I think this satisfies the issue so I'll close.