Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

blog post re ctfe ub change observed in 1.64. #1028

Merged
merged 17 commits into from Sep 15, 2022

Conversation

pnkfelix
Copy link
Member

@pnkfelix pnkfelix commented Sep 13, 2022

@Mark-Simulacrum
Copy link
Member

I am thinking this ought to go on the main blog, rather than Inside Rust; it feels aimed at average users more so than rust project developers.

I'll echo commentary from Zulip around "why is that flag not the default"; I think we might want to give an answer there.

@pnkfelix
Copy link
Member Author

I am thinking this ought to go on the main blog, rather than Inside Rust; it feels aimed at average users more so than rust project developers.

I had internally debated about where it should go. In some ways, I chose "Inside Rust" because I didn't want to cause undue alarm amongst our users.

But this feedback has pushed me back over the other direction; I think I can trust our users to take the time to understand what this post is saying.

I'll echo commentary from Zulip around "why is that flag not the default"; I think we might want to give an answer there.

Yep, I'll add that in as well. (As well as noting that maybe it will be turned on by default in the future, if we determine that the performance cost is sufficently low.)

@pnkfelix
Copy link
Member Author

pnkfelix commented Sep 14, 2022

Okay hopefully I can now say I'm done wordsmithing here. :)

(Oh, and I changed the file name to 2022-09-15, since I figure this is unlikely to get pushed to the Rust blog as soon as tomorrow. The filename I chose may be wishful thinking, but we do want the post published well before the 1.64.0 release on 2022-09-22)

pnkfelix and others added 8 commits September 14, 2022 18:50
…ommand to use to try out the beta.

Co-authored-by: Wesley Wiser <wwiser@gmail.com>
Co-authored-by: Wesley Wiser <wwiser@gmail.com>
Co-authored-by: Wesley Wiser <wwiser@gmail.com>
… ...".

It wasn't adding anything beyond saying that the status quo might be acceptable,
which is already implied by the later text.
…cope of the

problem described in this post is limited to the intersection of const-eval and
unsafe.
Copy link
Member

@wesleywiser wesleywiser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me but I'd love if @oli-obk had a chance to review as well!

Co-authored-by: Wesley Wiser <wwiser@gmail.com>
@pnkfelix pnkfelix merged commit 147dc8f into rust-lang:master Sep 15, 2022
@pnkfelix
Copy link
Member Author

This looks good to me but I'd love if @oli-obk had a chance to review as well!

oh, just so its clear, Oli did look at an earlier draft of this; their feedback was delivered on zulip (and was what @Mark-Simulacrum was referencing in their comment above).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants