Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add docs.rs post about fewer targets #603

Closed
wants to merge 4 commits into from

Conversation

jyn514
Copy link
Member

@jyn514 jyn514 commented May 27, 2020

The 'no earlier than a month' timeline is completely arbitrary, I can make that longer or shorter. The sections are not ordered super well, I'm happy to change the order. I'd appreciate help making it less wordy,

I would have written a shorter letter, but I did not have the time.

I contacted @retep998 about mentioning winapi explicitly but haven't heard back yet, we should either get confirmation that's ok or remove the mention before publishing the post. and they said that was fine, they're working on adding explicit targets now (retep998/winapi-rs#897).

r? @pietroalbini

@jyn514
Copy link
Member Author

jyn514 commented May 27, 2020

Oh, and this time it's an inside-rust post ;)

@XAMPPRocky
Copy link
Member

I think this one should also be on the main blog. It primarily affects users of Rust and docs.rs, it’s not really about the development/developers of Rust or docs.rs.

Copy link
Member

@pietroalbini pietroalbini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a couple comments.

I think we should actually give a date when we will flip the switch: if we don't people are going to rush updating their crates, as they don't actually know if they can wait a couple of weeks. Instead, if a timeline is given they can plan when they want to make a change.

I'll also check in with the core team whether to post this on the main blog or not.

## What does this change?

Currently, docs.rs builds documentation for all [tier 1 platforms][platform support] by default.
After this change, docs.rs will only build one platform by default.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's specify this will build on x86_64-unknown-linux-gnu.


More information on targets is available in the [platform support] page.
You can learn more about the change in [the issue proposing it][docs.rs#343] and [the PR with the implementation][docs.rs#532].
If you want to discuss the change with the docs.rs team, feel free to join the [docs.rs discord channel].
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's also recommend opening an issue.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I put a default title of 'Changing default targets', but people can still change it to anything if they like.

@jyn514
Copy link
Member Author

jyn514 commented May 28, 2020

I think we should actually give a date when we will flip the switch: if we don't people are going to rush updating their crates, as they don't actually know if they can wait a couple of weeks. Instead, if a timeline is given they can plan when they want to make a change.

I don't mind giving a date, but I do say 'no earlier than July 1st' so people don't have to rush.

@pietroalbini
Copy link
Member

We decided to open an RFC before actually going ahead with this change. Closing the post in the meantime.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants