Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Source-based code coverage in nightly #725

Merged
merged 3 commits into from
Nov 12, 2020

Conversation

tmandry
Copy link
Member

@tmandry tmandry commented Nov 11, 2020

@tmandry tmandry requested review from a team as code owners November 11, 2020 02:36
@richkadel
Copy link

lgtm

Copy link
Member

@wesleywiser wesleywiser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@tmandry
Copy link
Member Author

tmandry commented Nov 12, 2020

Can we get this published? @Mark-Simulacrum

@Mark-Simulacrum
Copy link
Member

Hm, sure -- did llvm-cov already hit nightlies? I think the answer is probably yes, rust-lang/rust#78947 landed 20 hours ago...

@Mark-Simulacrum
Copy link
Member

If you want to bump the date to Nov 12th then I can merge.

@tmandry
Copy link
Member Author

tmandry commented Nov 12, 2020

Hmm, I just checked and I'm not seeing llvm-cov.

@Mark-Simulacrum
Copy link
Member

Ok, seems like we should wait till the next nightly or fix that before publishing? Otherwise most people can't make easy use of it, right?

(If that's the wrong impression then we can merge now)

@tmandry
Copy link
Member Author

tmandry commented Nov 12, 2020

Possibly. You can also install it directly which should work just as well. I think the guide covers this.

@Mark-Simulacrum
Copy link
Member

Okay, I'm happy to merge with the date bumped then.

@tmandry
Copy link
Member Author

tmandry commented Nov 12, 2020

Done!

@Mark-Simulacrum Mark-Simulacrum merged commit cb6b275 into rust-lang:master Nov 12, 2020
@shamatar
Copy link

Are there any known incompatibilities or problems that would stop from obtaining code coverage from the test binary that is built like

RUSTFLAGS="-Zinstrument-coverage" cargo +nightly test --no-run
LLVM_PROFILE_FILE="full_tests.profraw" target/debug/deps/...

@richkadel
Copy link

What happens when you try it? If it's not working for you, the way you expect it should, can you file a new issue and include what the failures are?

Thank you!

# Trying it out

Work on the implementation [began back in April][MCP], and [many PRs
later][PRs], it’s ready for you to try. All you need is a recent nightly and

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be helpful if you said exactly what nightly is needed, instead of saying "recent nightly". Running rustup update nightly isn't enough to guarantee that a user will have the correct nightly, because rustup will skip recently nightly releases if they're missing components (like miri)

jackh726 pushed a commit to jackh726/blog.rust-lang.org that referenced this pull request Jul 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants