Fix failing tidy #549
Merged
Fix failing tidy #549
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When this book was included into https://github.com/rust-lang/rust as a submodule, `tidy` started failing on Windows. Not sure how this passed through Appveyor. This patch sets `.gitattributes` to the same value that is used by the main repo. @steveklabnik @carols10cents Could you please merge this sooner rather than later
|
looks good to me! |
|
Thanks! |
frewsxcv
added a commit
to frewsxcv/rust
that referenced
this pull request
Mar 22, 2017
Update the book submodule and fix tidy When the book was included into https://github.com/rust-lang/rust as a submodule, tidy started failing on Windows. rust-lang/book#549 fixed the problem, now the submodule needs to be updated.
This was referenced Dec 1, 2018
mark-i-m
pushed a commit
to rust-lang/rustc-dev-guide
that referenced
this pull request
Dec 1, 2018
This happens every time a new doc submodule is added to https://github.com/rust-lang/rust. cc rust-lang/book#549 rust-lang/reference#36 rust-lang/rust-by-example#1018
bors bot
added a commit
to rust-embedded/book
that referenced
this pull request
Feb 10, 2019
127: Fix failing tidy (line endings on Windows) r=japaric a=petrochenkov This happens every time a new doc submodule is added to https://github.com/rust-lang/rust. cc rust-lang/book#549 rust-lang/reference#36 rust-lang/rust-by-example#1018 rust-lang/rustc-dev-guide#246 Co-authored-by: Vadim Petrochenkov <vadim.petrochenkov@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When this book was included into https://github.com/rust-lang/rust as a submodule,
tidystarted failing on Windows.Not sure how this passed through Appveyor.
This patch sets
.gitattributesto the same value that is used by the main repo.@steveklabnik @carols10cents Could you please merge this sooner rather than later