Skip to content

Commit

Permalink
Auto merge of #12972 - ehuss:windows-gnu-ignore-json-target, r=epage
Browse files Browse the repository at this point in the history
Ignore changing_spec_relearns_crate_types on windows-gnu

This disables the `custom_target::changing_spec_relearns_crate_types` on windows-gnu targets for the same reason as #12763. The update to LLVM 17 has started to cause lld to crash when using a custom target. cc rust-lang/rust#115985

I surveyed the rest of the testsuite, and I don't see any other tests that perform linking with custom targets.
  • Loading branch information
bors committed Nov 14, 2023
2 parents 4e02f11 + 8161ba5 commit 360059e
Showing 1 changed file with 2 additions and 0 deletions.
2 changes: 2 additions & 0 deletions tests/testsuite/custom_target.rs
Original file line number Diff line number Diff line change
Expand Up @@ -178,6 +178,8 @@ fn changing_spec_rebuilds() {
}

#[cargo_test(nightly, reason = "requires features no_core, lang_items")]
// This is randomly crashing in lld. See https://github.com/rust-lang/rust/issues/115985
#[cfg_attr(all(windows, target_env = "gnu"), ignore = "windows-gnu lld crashing")]
fn changing_spec_relearns_crate_types() {
// Changing the .json file will invalidate the cache of crate types.
let p = project()
Expand Down

0 comments on commit 360059e

Please sign in to comment.