Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tracking Issue for default-run #7032

Closed
ehuss opened this issue Jun 13, 2019 · 4 comments · Fixed by #7056
Closed

Tracking Issue for default-run #7032

ehuss opened this issue Jun 13, 2019 · 4 comments · Fixed by #7056
Labels
C-tracking-issue Category: A tracking issue for something unstable. disposition-merge FCP with intent to merge finished-final-comment-period FCP complete T-cargo Team: Cargo

Comments

@ehuss
Copy link
Contributor

ehuss commented Jun 13, 2019

Original Issue: #2200
Implementation PR: #5710
Documentation: https://doc.rust-lang.org/nightly/cargo/reference/unstable.html#default-run

Summary

The default-run feature provides a way to specify which binary will be run by default by cargo run when there are multiple binaries.

[package]
default-run = "foo"

Unresolved issues

  • The error message when default-run specifies a non-existing binary is not great (it just says "no bin target named …"). I think it should point the user to the default-run definition.
@ehuss ehuss added T-cargo Team: Cargo C-tracking-issue Category: A tracking issue for something unstable. labels Jun 13, 2019
@ehuss
Copy link
Contributor Author

ehuss commented Jun 13, 2019

I'd like to propose stabilizing this feature.

@rfcbot merge

Stabilization Target: 1.37 — Release date August 15th 2019

This feature has been around for almost a year. There haven't been any issues, and I can't think of any changes that would be needed. It is fairly straightforward. It is not a high-demand feature, but there are some projects using it, and presumably more would use it if it weren't nightly-only.

The error messages should be cleaned up a little when it is stabilized. Documentation will also be need to be updated.

@rfcbot
Copy link
Collaborator

rfcbot commented Jun 13, 2019 •
edited by alexcrichton

Team member @ehuss has proposed to merge this. The next step is review by the rest of the tagged team members:

No concerns currently listed.

Once a majority of reviewers approve (and at most 2 approvals are outstanding), this will enter its final comment period. If you spot a major issue that hasn't been raised at any point in this process, please speak up!

See this document for info about what commands tagged team members can give me.

@rfcbot rfcbot added proposed-final-comment-period An FCP proposal has started, but not yet signed off. disposition-merge FCP with intent to merge labels Jun 13, 2019
@ehuss ehuss mentioned this issue Jun 13, 2019
Merged
@joshtriplett
Copy link
Member

@rfcbot reviewed

@rfcbot rfcbot added final-comment-period FCP — a period for last comments before action is taken and removed proposed-final-comment-period An FCP proposal has started, but not yet signed off. labels Jun 13, 2019
@rfcbot
Copy link
Collaborator

rfcbot commented Jun 13, 2019

🔔 This is now entering its final comment period, as per the review above. 🔔

@ehuss ehuss mentioned this issue Jun 21, 2019
Merged
bors added a commit that referenced this issue Jun 21, 2019
@bors
Auto merge of #7056 - ehuss:default-run-stabilize, r=alexcrichton
9733561 
Stabilize default-run

This stabilizes the default-run feature.

I've included some error message changes. If `default-run` specifies an unknown binary, it now tells you that the `default-run` field is incorrect and which manifest it is located in, instead of just saying "could not determine which binary to run".

I also consolidated some of the suggestion code so it is not repeated all over.

Closes #7032
@rfcbot rfcbot added finished-final-comment-period FCP complete and removed final-comment-period FCP — a period for last comments before action is taken labels Jun 23, 2019
@bkchr bkchr mentioned this issue Jul 24, 2019
Closed
@RalfJung RalfJung mentioned this issue Aug 15, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C-tracking-issue Category: A tracking issue for something unstable. disposition-merge FCP with intent to merge finished-final-comment-period FCP complete T-cargo Team: Cargo
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Stabilize default-run ehuss/cargo
3 participants
@ehuss @joshtriplett @rfcbot