Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[beta] Fix documenting with undocumented dependencies. #10325

Merged
merged 1 commit into from
Jan 25, 2022
Merged

[beta] Fix documenting with undocumented dependencies. #10325

merged 1 commit into from
Jan 25, 2022

Commits on Jan 25, 2022

  1. Auto merge of rust-lang#10324 - ehuss:fix-doc-undocumented-dep, r=ale… 

    …xcrichton

Fix documenting with undocumented dependencies.

rust-lang#10201 introduced a bug where dependencies that have `doc=false` weren't being built at all when running `cargo doc` if the project did not have any binaries.  That means the rmeta file was missing, and the `--extern` flag was not being passed to rustdoc.

The solution is to ensure the `rmeta` file gets generated, but only skip generating the `CompileMode::Doc` unit for undocumented dependencies.

This unblocks the bootstrap bump.
    @bors @ehuss
    bors authored and ehuss committed Jan 25, 2022
    Configuration menu
    Copy the full SHA
    a01b17c View commit details
    Browse the repository at this point in the history