Move snapshot tests into testsuite #10638
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rust-highfive
added
the
S-waiting-on-review
epage
approved these changes
May 7, 2022
tests/testsuite/main.rs
Outdated
Comment on lines
135
to
141
| macro_rules! test_root { | ||
| () => { | ||
| std::path::Path::new(file!()).parent().unwrap() | ||
| }; | ||
| } | ||
|
|
||
| pub(crate) use test_root; |
There was a problem hiding this comment.
- This might be good to have in
cargo_test_support - Thinking about the name, I think its a bit misleading. I think people will assume this will be the crate root or
tests/root.
Neither of these is worth holding this up and the naming issue, I don't have better ideas for. Still wanted to get this out there to seed thoughts
There was a problem hiding this comment.
Looks like I have to redo a commit either way so I can change it. Do you like test_path?
There was a problem hiding this comment.
That implies the path to the current file. What about test_dir? _root implies the parent of all dirs while _dir might not be so bad.
There was a problem hiding this comment.
I changed it to curr_dir as it seemed to fit the best
Muscraft
force-pushed
the
move-snapshot-tests
branch
from
b5029e2
to
639f3bd
Compare
|
@bors r+ |
|
📌 Commit 639f3bd has been approved by |
bors
added
S-waiting-on-bors
|
☀️ Test successful - checks-actions |
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
May 12, 2022
Update cargo 20 commits in a44758ac805600edbb6ba51e7e6fb81a6077c0cd..3f052d8eed98c6a24f8b332fb2e6e6249d12d8c1 2022-05-04 02:29:34 +0000 to 2022-05-12 15:19:04 +0000 - pre-stabilization documentation for workspace inheritance (rust-lang/cargo#10659) - test: Make curr_dir work in/out of workspace (rust-lang/cargo#10658) - Fix no_cross_doctests race condition. (rust-lang/cargo#10660) - Fix typo (rust-lang/cargo#10657) - feat(install): Support `foo@version` like cargo-add (rust-lang/cargo#10650) - fix typos found by the `typos-cli` crate (rust-lang/cargo#10649) - feat(yank): Support foo@version like cargo-add (rust-lang/cargo#10597) - add `cargo-features` to unstable docs for workspace inheritance (rust-lang/cargo#10648) - Use the traits added to the Rust 2021 Edition prelude (rust-lang/cargo#10646) - Pass `--target` to `rustdoc` for `cargo test` if specified with host target. (rust-lang/cargo#10594) - Fix use of .. in dep-info-basedir (rust-lang/cargo#10281) - fix some typos (rust-lang/cargo#10639) - Move snapshot tests into testsuite (rust-lang/cargo#10638) - Improve support of condition compilation checking (rust-lang/cargo#10566) - When documenting private items in a binary, ignore warnings about links to private items (rust-lang/cargo#10142) - Extend pkgid syntax with ``@`` support (rust-lang/cargo#10582) - move one `snapshot/add` test into `testsuite/cargo_add/` (rust-lang/cargo#10631) - Add caveat for covering features (rust-lang/cargo#10605) - Improve CARGO_ENCODED_RUSTFLAGS and CARGO_ENCODED_RUSTDOCFLAGS variables docs (rust-lang/cargo#10633) - reorganize `snapshot` tests to better work in contexts that sort by extension (rust-lang/cargo#10629)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This moves all tests from the
snapshotfolder into thetestsuitefolder as described by this comment. A macro was also added so there is no need to specify the path in asnapshottest just the file. This was done for ease of refactoring and ease of porting new tests tosnapshotclose #10627
r? @epage