Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Corrected documentation of how to cache binaries installed with cargo install in CI workflows #11592

Merged
merged 1 commit into from
Jan 18, 2023

Conversation

jofas
Copy link
Contributor

@jofas jofas commented Jan 18, 2023

Fix for #11513. Updated the cargo book documentation on how to cache the $CARGO_HOME directory in CI workflows (added that the .crates.toml and .crates2.json files must be cached alongside the /bin folder, if installed binaries are cached)

@rustbot
Copy link
Collaborator

rustbot commented Jan 18, 2023

r? @weihanglo

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jan 18, 2023
Copy link
Member

@weihanglo weihanglo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! This looks good to me.

By the way, we prefer a descriptive PR title instead of “fixing issue number X”, for the sake of being friendly when searching old PRs, and also saving one click. It would be better if you could simply update the title.

@jofas jofas changed the title Fix for issue 11513 Corrected documentation of how to cache binaries installed with cargo install in CI workflows Jan 18, 2023
@jofas
Copy link
Contributor Author

jofas commented Jan 18, 2023

By the way, we prefer a descriptive PR title instead of “fixing issue number X”, for the sake of being friendly when searching old PRs, and also saving one click. It would be better if you could simply update the title.

Like this?

@weihanglo
Copy link
Member

We don't really strictly follow any rule. A proper title is just right. Thank you!

@bors r+

@bors
Copy link
Collaborator

bors commented Jan 18, 2023

📌 Commit 37f0510 has been approved by weihanglo

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 18, 2023
@bors
Copy link
Collaborator

bors commented Jan 18, 2023

⌛ Testing commit 37f0510 with merge fc2242a...

@bors
Copy link
Collaborator

bors commented Jan 18, 2023

☀️ Test successful - checks-actions
Approved by: weihanglo
Pushing fc2242a to master...

@bors bors merged commit fc2242a into rust-lang:master Jan 18, 2023
bors pushed a commit to rust-lang-ci/rust that referenced this pull request Jan 19, 2023
3 commits in a5d47a72595dd6fbe7d4e4f6ec20dc5fe724edd1..50eb688c2bbea5de5a2e8496230a7428798089d1
2023-01-16 18:51:50 +0000 to 2023-01-19 10:09:05 +0000

- Normalize git deps when doing `cargo vendor` for resolving deps inherited from a workspace (rust-lang/cargo#11414)
- Ignore `workspace.default-members` when running `cargo install` on root package of a non-virtual workspace (rust-lang/cargo#11067)
- Corrected documentation of how to cache binaries installed with `cargo install` in CI workflows (rust-lang/cargo#11592)
bors added a commit to rust-lang-ci/rust that referenced this pull request Jan 19, 2023
Update cargo

3 commits in a5d47a72595dd6fbe7d4e4f6ec20dc5fe724edd1..50eb688c2bbea5de5a2e8496230a7428798089d1 2023-01-16 18:51:50 +0000 to 2023-01-19 10:09:05 +0000

- Normalize git deps when doing `cargo vendor` for resolving deps inherited from a workspace (rust-lang/cargo#11414)
- Ignore `workspace.default-members` when running `cargo install` on root package of a non-virtual workspace (rust-lang/cargo#11067)
- Corrected documentation of how to cache binaries installed with `cargo install` in CI workflows (rust-lang/cargo#11592)

r? `@ghost`
@ehuss ehuss added this to the 1.68.0 milestone Jan 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants