Drop derive feature from serde in cargo-platform #11915
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @ehuss (or someone else) soon. Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (
|
rustbot
added
A-cfg-expr
|
CI should be fixed now |
|
Thanks! @bors r+ |
bors
added
S-waiting-on-bors
|
☀️ Test successful - checks-actions |
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Apr 1, 2023
Update cargo 9 commits in 145219a9f089f8b57c09f40525374fbade1e34ae..0e474cfd7b16b018cf46e95da3f6a5b2f1f6a9e7 2023-03-27 01:56:36 +0000 to 2023-03-31 23:15:58 +0000 - Add delays to network retries. (rust-lang/cargo#11881) - Add a note to `cargo logout` that it does not revoke the token. (rust-lang/cargo#11919) - Sync external-tools JSON docs. (rust-lang/cargo#11918) - Drop derive feature from serde in cargo-platform (rust-lang/cargo#11915) - Disable test_profile test on windows-gnu (rust-lang/cargo#11916) - src/doc/src/reference/build-scripts.md: a{n =>} benchmark target (rust-lang/cargo#11908) - Documented working directory behaviour for `cargo test`, `cargo bench` and `cargo run` (rust-lang/cargo#11901) - docs(contrib): Link to office hours doc (rust-lang/cargo#11903) - chore: Upgrade to clap v4.2 (rust-lang/cargo#11904)
bors
added a commit
that referenced
this pull request
Apr 23, 2023
Bump versions of local crates
These crates have had the following changes since their last version bump:
- `cargo-platform`
- #11915 — Drop derive feature from serde in cargo-platform
- `crates-io`
- #11951 — Fix credential token format validation.
- #11952 — Validate token on publish.
AFAICT, none of these seem to warrant a semver breaking change.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cargo-platformintroduces a depdency toserde_derivevia thederivefeature ofserde, yet the crate does not use it.Additional information
This slightly hurts compile times for rust-analyzer due to the dependencyh betweennot relevant anymore, so if this is too much churn feel free to closeserdeandserde_derivethis constructs, see rust-lang/rust-analyzer#14450