Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Upgrade to clap v4.2 #11904

Merged
merged 1 commit into from Mar 28, 2023
Merged

chore: Upgrade to clap v4.2 #11904

merged 1 commit into from Mar 28, 2023

Conversation

epage
Copy link
Contributor

@epage epage commented Mar 28, 2023

Tests in master are currently failing because its building with clap v4.2 but the tests have snapshots from v4.1

Tests in `master` are currently failing because its building with clap
v4.2 but the tests have snapshots from v4.1
@rustbot
Copy link
Collaborator

rustbot commented Mar 28, 2023

r? @ehuss

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Mar 28, 2023
Copy link
Contributor

@Muscraft Muscraft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Changelog for clap 4.2.0 and the relevant change

@Muscraft
Copy link
Contributor

@bors r+

@bors
Copy link
Collaborator

bors commented Mar 28, 2023

📌 Commit 6feea34 has been approved by Muscraft

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 28, 2023
@bors
Copy link
Collaborator

bors commented Mar 28, 2023

⌛ Testing commit 6feea34 with merge a6e1e26...

@bors
Copy link
Collaborator

bors commented Mar 28, 2023

☀️ Test successful - checks-actions
Approved by: Muscraft
Pushing a6e1e26 to master...

1 similar comment
@bors
Copy link
Collaborator

bors commented Mar 28, 2023

☀️ Test successful - checks-actions
Approved by: Muscraft
Pushing a6e1e26 to master...

@bors
Copy link
Collaborator

bors commented Mar 28, 2023

👀 Test was successful, but fast-forwarding failed: 422 Changes must be made through a pull request.

@bors bors merged commit a6e1e26 into rust-lang:master Mar 28, 2023
18 checks passed
@epage epage deleted the clap branch March 29, 2023 00:03
bors added a commit to rust-lang-ci/rust that referenced this pull request Apr 1, 2023
Update cargo

9 commits in 145219a9f089f8b57c09f40525374fbade1e34ae..0e474cfd7b16b018cf46e95da3f6a5b2f1f6a9e7
2023-03-27 01:56:36 +0000 to 2023-03-31 23:15:58 +0000
- Add delays to network retries. (rust-lang/cargo#11881)
- Add a note to `cargo logout` that it does not revoke the token. (rust-lang/cargo#11919)
- Sync external-tools JSON docs. (rust-lang/cargo#11918)
- Drop derive feature from serde in cargo-platform (rust-lang/cargo#11915)
- Disable test_profile test on windows-gnu (rust-lang/cargo#11916)
- src/doc/src/reference/build-scripts.md: a{n =>} benchmark target (rust-lang/cargo#11908)
- Documented working directory behaviour for `cargo test`, `cargo bench` and `cargo run` (rust-lang/cargo#11901)
- docs(contrib): Link to office hours doc (rust-lang/cargo#11903)
- chore: Upgrade to clap v4.2 (rust-lang/cargo#11904)
@ehuss ehuss added this to the 1.70.0 milestone Apr 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants