Add include and exclude information to metadata
#13330
Conversation
|
r? @epage (rustbot has picked a reviewer for you, use r? to override) |
rustbot
added
the
S-waiting-on-review
| @@ -106,6 +106,8 @@ pub struct SerializedPackage { | |||
| metabuild: Option<Vec<String>>, | |||
| default_run: Option<String>, | |||
| rust_version: Option<RustVersion>, | |||
| include: Vec<String>, | |||
There was a problem hiding this comment.
While it might be useful to have include and exclude in cargo metadata output, it doesn't seem to be a proper way to fix rust-lang/rust-clippy#11677. The solution might end up reimplement the logic Cargo find and package files, which includes .gitignore, shell glob syntax, symlinks handling, git dirty status, and other details (see #11405). cargo package --list might be more reliable, but not 100% accurate (see #8407 and #11666).
I would suggest starting the discussion from an issue, and jump back to implementation when the design is settled.
There was a problem hiding this comment.
Yes that's a good point. I'll open an issue so it can be discussed.
weihanglo
added
S-needs-design
weihanglo
removed
the
S-waiting-on-author
|
☔ The latest upstream changes (presumably #13703) made this pull request unmergeable. Please resolve the merge conflicts. |
bors
added
the
S-waiting-on-author
I'll need this information to fix rust-lang/rust-clippy#11677. I'll also send a PR to
cargo_metadataonce merged.Of course, if there is another way to retrieve this information without needing this PR, I'd love to hear it. :)