Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test(metadata): Show behavior with TOML-specific types #13703

Merged
merged 1 commit into from Apr 4, 2024
Merged

test(metadata): Show behavior with TOML-specific types #13703

merged 1 commit into from Apr 4, 2024

Conversation

epage
Copy link
Contributor

@epage epage commented Apr 4, 2024

What does this PR try to resolve?

The goal is to know if/when these change so we can have a conversation about what to do.

How should we test and review this PR?

Additional information

@epage
test(metadata): Show behavior with TOML-specific types
b930f7a 
The goal is to know if/when these change so we can have a conversation
about what to do.
@rustbot
Copy link
Collaborator

rustbot commented Apr 4, 2024

r? @ehuss

rustbot has assigned @ehuss.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Apr 4, 2024
weihanglo
weihanglo reviewed Apr 4, 2024
View reviewed changes
Copy link
Member

@weihanglo weihanglo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How was this dicovered and do we have any prior discussion of it?

@epage
Copy link
Contributor Author

epage commented Apr 4, 2024

How was this dicovered and do we have any prior discussion of it?

I discovered it when I merged tomls functionality into toml_edit. I've previously glossed over this. In office hours, this came up for a couple of reasons

  • Caching of Cargo.toml parsing in alternative formats which could end up persisting this
  • Being prepared for a day when a cargo team member isn't maintaining toml

@arlosi
Copy link
Contributor

arlosi commented Apr 4, 2024

@bors r+

@bors
Copy link
Collaborator

bors commented Apr 4, 2024

📌 Commit b930f7a has been approved by arlosi

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 4, 2024
@weihanglo
Copy link
Member

Being prepared for a day when a cargo team member isn't maintaining toml

I hope everything is okay 🙏🏾.

@bors
Copy link
Collaborator

bors commented Apr 4, 2024

⌛ Testing commit b930f7a with merge a9a0746...

@epage
Copy link
Contributor Author

epage commented Apr 4, 2024

No announcements, more being prepared

@bors
Copy link
Collaborator

bors commented Apr 4, 2024

☀️ Test successful - checks-actions
Approved by: arlosi
Pushing a9a0746 to master...

@bors bors merged commit a9a0746 into rust-lang:master Apr 4, 2024
21 checks passed
@bors bors mentioned this pull request Apr 4, 2024
Draft
@epage epage deleted the toml branch April 5, 2024 00:59
@weihanglo weihanglo mentioned this pull request Apr 6, 2024
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Apr 6, 2024
@bors
Auto merge of rust-lang#123527 - weihanglo:update-cargo, r=weihanglo
23d47db 
Update cargo

9 commits in 0637083df5bbdcc951845f0d2eff6999cdb6d30a..28e7b2bc0a812f90126be30f48a00a4ada990eaa
2024-04-02 23:55:05 +0000 to 2024-04-05 19:31:01 +0000
- refactor(toml): Decouple target discovery from Target creation (rust-lang/cargo#13701)
- Don't depend on `?` affecting type inference in weird ways (rust-lang/cargo#13706)
- test(metadata): Show behavior with TOML-specific types (rust-lang/cargo#13703)
- fix: adjust tracing verbosity in list_files_git (rust-lang/cargo#13704)
- doc: comments on `PackageRegistry` (rust-lang/cargo#13698)
- Switch to using gitoxide by default for listing files (rust-lang/cargo#13696)
- Allow precise update to prerelease. (rust-lang/cargo#13626)
- refactor(toml): Split out an explicit step to resolve `Cargo.toml` (rust-lang/cargo#13693)
- chore(deps): update rust crate base64 to 0.22.0 (rust-lang/cargo#13675)

r? ghost
@rustbot rustbot added this to the 1.79.0 milestone Apr 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@weihanglo weihanglo weihanglo left review comments

Assignees

@ehuss ehuss

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
1.79.0
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@epage @rustbot @arlosi @bors @weihanglo @ehuss