Add unknown-lints lint
#13639
Open
Add unknown-lints lint
#13639
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
A-workspaces
epage
reviewed
Mar 25, 2024
| { | ||
| if let Some(cargo_lints) = lints.get("cargo") { | ||
| for (name, _) in cargo_lints.iter() { | ||
| let normalized_name = name.replace("-", "_"); |
There was a problem hiding this comment.
This is having me lean more towards normalizing earlier in the process
epage
reviewed
Mar 25, 2024
Comment on lines
+198
to
+201
| if let Some(lints) = original_toml | ||
| .workspace | ||
| .as_ref() | ||
| .map_or(&None, |ws| &ws.lints) |
There was a problem hiding this comment.
imo this should be treated as a separate "workspace" lint that is only subject to workspace.lints so we have consistency between virtual and real workspace packages.
epage
reviewed
Mar 25, 2024
| @@ -763,7 +763,6 @@ fn cargo_lints_nightly_required() { | |||
| authors = [] | |||
|
|
|||
| [lints.cargo] | |||
| "unused-features" = "deny" | |||
There was a problem hiding this comment.
Why were these here and why are they being removed?
|
☔ The latest upstream changes (presumably #13740) made this pull request unmergeable. Please resolve the merge conflicts. |
|
r? epage |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a lint for
unknown-lintssimilarrustc::unknown-lints. This will help users know when they are passing something tocargothatcargodoesn't understand.