Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(new): Dont say were adding to a workspace when a regular package is in root #13987

Merged
merged 1 commit into from
May 31, 2024
Merged

fix(new): Dont say were adding to a workspace when a regular package is in root #13987

merged 1 commit into from
May 31, 2024

Conversation

epage
Copy link
Contributor

@epage epage commented May 30, 2024

Fixes #13985

@rustbot
Copy link
Collaborator

rustbot commented May 30, 2024

r? @ehuss

rustbot has assigned @ehuss.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added Command-new S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 30, 2024
@linyihai
Copy link
Contributor

Looks good for me, thank you for update.

@ehuss
Copy link
Contributor

ehuss commented May 31, 2024

Thanks!

@bors r+

@bors
Copy link
Collaborator

bors commented May 31, 2024

📌 Commit 26c1678 has been approved by ehuss

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 31, 2024
@bors
Copy link
Collaborator

bors commented May 31, 2024

⌛ Testing commit 26c1678 with merge d04355a...

@bors
Copy link
Collaborator

bors commented May 31, 2024

☀️ Test successful - checks-actions
Approved by: ehuss
Pushing d04355a to master...

@bors bors merged commit d04355a into rust-lang:master May 31, 2024
21 checks passed
@epage epage deleted the new branch May 31, 2024 18:14
@weihanglo weihanglo mentioned this pull request Jun 1, 2024
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Jun 1, 2024
@bors
Auto merge of rust-lang#125835 - weihanglo:update-cargo, r=weihanglo
dcc9a8f 
Update cargo

9 commits in 431db31d0dbeda320caf8ef8535ea48eb3093407..7a6fad0984d28c8330974636972aa296b67c4513
2024-05-28 18:17:31 +0000 to 2024-05-31 22:26:03 +0000
- fix(config): Ensure `--config net.git-fetch-with-cli=true` is respected (rust-lang/cargo#13992)
- Fix libcurl proxy documentation link (rust-lang/cargo#13990)
- fix(new): Dont say were adding to a workspace when a regular package is in root (rust-lang/cargo#13987)
- fix: adjust custom err from cert-check due to libgit2 1.8 change (rust-lang/cargo#13970)
- fix(toml): Ensure targets are in a deterministic order (rust-lang/cargo#13989)
- doc(cargo-package): explain no guarantee of vcs provenance (rust-lang/cargo#13984)
- chore: fix some comments (rust-lang/cargo#13982)
- feat: stabilize `cargo update --precise <yanked>` (rust-lang/cargo#13974)
- Update openssl-src to 111.28.2+1.1.1w (rust-lang/cargo#13976)

r? ghost
@rustbot rustbot added this to the 1.80.0 milestone Jun 1, 2024
@ehuss ehuss mentioned this pull request Jun 29, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@ehuss ehuss

Labels
Command-new S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
1.80.0
Development

Successfully merging this pull request may close these issues.

cargo new: Confusing error message about adding to a workspace
5 participants
@epage @rustbot @linyihai @ehuss @bors