feat: stabilize cargo update --precise <yanked>
#13974
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
A-cli-help
|
@rfcbot fcp merge Although we discussed this earlier today as a team, it's better to have a record here. |
|
Team member @weihanglo has proposed to merge this. The next step is review by the rest of the tagged team members: No concerns currently listed. Once a majority of reviewers approve (and at most 2 approvals are outstanding), this will enter its final comment period. If you spot a major issue that hasn't been raised at any point in this process, please speak up! See this document for info about what commands tagged team members can give me. |
rfcbot
added
proposed-final-comment-period
|
🔔 This is now entering its final comment period, as per the review above. 🔔 |
|
Thanks! @bors r+ |
bors
added
S-waiting-on-bors
bors
added a commit
that referenced
this pull request
May 29, 2024
feat: stabilize `cargo update --precise <yanked>` ### What does this PR try to resolve? Stabilize `cargo update --precise <yanked>`. The cargo team has discussed the stabilization in the meeting today. The interface of this is quite small and not as controversial as `--precise <pre-release>`, since there is no version requirement operators involved. We'd like to move forward and stabilize this part. Note that `--precise <yanked>` allows using yanked version only for the specified package, We leave the cascading allowing yanked versions (e.g. <#4225 (comment)>) as a future extension. ### How should we test and review this PR? Check if any adjustment needed for warnings and CLI help text. ### Additional information cc <#4225>.
|
💔 Test failed - checks-actions |
bors
added
S-waiting-on-review
Network error. @bors retry |
bors
added
S-waiting-on-bors
bors
added a commit
that referenced
this pull request
May 29, 2024
feat: stabilize `cargo update --precise <yanked>` ### What does this PR try to resolve? Stabilize `cargo update --precise <yanked>`. The cargo team has discussed the stabilization in the meeting today. The interface of this is quite small and not as controversial as `--precise <pre-release>`, since there is no version requirement operators involved. We'd like to move forward and stabilize this part. Note that `--precise <yanked>` allows using yanked version only for the specified package, We leave the cascading allowing yanked versions (e.g. <#4225 (comment)>) as a future extension. ### How should we test and review this PR? Check if any adjustment needed for warnings and CLI help text. ### Additional information cc <#4225>.
|
💔 Test failed - checks-actions |
bors
added
S-waiting-on-review
|
@bors retry |
bors
added
S-waiting-on-bors
|
☀️ Test successful - checks-actions |
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jun 1, 2024
Update cargo 9 commits in 431db31d0dbeda320caf8ef8535ea48eb3093407..7a6fad0984d28c8330974636972aa296b67c4513 2024-05-28 18:17:31 +0000 to 2024-05-31 22:26:03 +0000 - fix(config): Ensure `--config net.git-fetch-with-cli=true` is respected (rust-lang/cargo#13992) - Fix libcurl proxy documentation link (rust-lang/cargo#13990) - fix(new): Dont say were adding to a workspace when a regular package is in root (rust-lang/cargo#13987) - fix: adjust custom err from cert-check due to libgit2 1.8 change (rust-lang/cargo#13970) - fix(toml): Ensure targets are in a deterministic order (rust-lang/cargo#13989) - doc(cargo-package): explain no guarantee of vcs provenance (rust-lang/cargo#13984) - chore: fix some comments (rust-lang/cargo#13982) - feat: stabilize `cargo update --precise <yanked>` (rust-lang/cargo#13974) - Update openssl-src to 111.28.2+1.1.1w (rust-lang/cargo#13976) r? ghost
rfcbot
added
finished-final-comment-period
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR try to resolve?
Stabilize
cargo update --precise <yanked>.The cargo team has discussed the stabilization in the meeting today.
The interface of this is quite small and not as controversial as
--precise <pre-release>,since there is no version requirement operators involved.
We'd like to move forward and stabilize this part.
Note that
--precise <yanked>allows using yanked version only for the specified package,We leave the cascading allowing yanked versions (e.g. #4225 (comment)) as a future extension.
How should we test and review this PR?
Check if any adjustment needed for warnings and CLI help text.
Additional information
cc #4225.