test: migrate some files to snapbox #14113
Conversation
rustbot
added
A-testing-cargo-itself
heisen-li
force-pushed
the
env_features_target
branch
from
1bf5eea
to
f7b0fac
Compare
| } | ||
|
|
||
| #[cargo_test] | ||
| fn list_builtin_aliases_with_descriptions() { |
There was a problem hiding this comment.
Since the output on the right is complete, the test case here is deleted.
| @@ -132,6 +178,7 @@ fn list_command_looks_at_path_case_mismatch() { | |||
| ); | |||
| } | |||
|
|
|||
| #[allow(deprecated)] | |||
There was a problem hiding this comment.
Since with_stdout_does_not_contain，add #[allow(deprecated)].
heisen-li
force-pushed
the
env_features_target
branch
from
f7b0fac
to
7c172ec
Compare
heisen-li
force-pushed
the
env_features_target
branch
3 times, most recently
from
cd4aa8c
to
464d232
Compare
|
☔ The latest upstream changes (presumably #14126) made this pull request unmergeable. Please resolve the merge conflicts. |
|
Could you clean up the commit history? |
tests/testsuite/cargo_command.rs
Outdated
| .with_stdout_data(str![[r#" | ||
| [CARGO_PATH] | ||
| "#]]) |
There was a problem hiding this comment.
So this was already a "self updating" test output and I believe the design of it means that there is little to evolve that we'd need to allow snapshotting more from this.
Should we keep the expected-str generation that was in here before, just switching the assert method used?
There was a problem hiding this comment.
It is not possible to just convert with_stdout to with_stdout_data, such as the error reported below:
--- Expected
++++ actual: stdout
1 - /home/heisen/temp/temp/temp/cargo/target/debug/cargo∅
1 + /home/heisen/temp/temp/temp/cargo/target/debug/cargo
Need to add line breaks.
There was a problem hiding this comment.
Adding in a newline is trivial and doesn't invalidate the idea I mentioned that this is unlikely to have surrounding text that gets regularly changed.
There was a problem hiding this comment.
It has been modified and you can see if it meets the requirements.
heisen-li
force-pushed
the
env_features_target
branch
5 times, most recently
from
d13e4b1
to
204d05d
Compare
heisen-li
force-pushed
the
env_features_target
branch
from
204d05d
to
c335fb0
Compare
What does this PR try to resolve?
Changes to the following documents were completed:
tests/testsuite/cargo_command.rstests/testsuite/cargo_env_config.rstests/testsuite/cargo_features.rstests/testsuite/cargo_targets.rspart of #14039