Port from bespoke assertions of snapbox #14039

epage · 2024-06-10T17:52:17Z

Traditionally, cargo-test-support has had bespoke assertions, requiring hand implemented diff algorithms. As there is less of a community around this, the knowledge is more specialized, its less likely to be documented, and we are on our own for feature development.

In #13980 and #14031, we introduced the use of snapbox as replacement for our own assertions and need to work to migrate to them.

Porting Instructions

1. Select a file to port

The files should have #![allow(deprecated)] at the top, e.g.

$ git pull --rebase
$ rg '#!.allow.deprecated' tests

Please check the comments on this issue for anyone to have claimed the file and then post that you claim the file

2. Remove `#![allow(deprecated)]` to identify what work is needed

If nothing, congrats, that was easy!

3. Resolve basic deprecations

Replace Execs::with_stdout("...") with

use cargo_test_support::prelude::*;
use cargo_test_support::str;

.with_stdout_data(str![])

Replace Execs::with_stderr("...") with

use cargo_test_support::prelude::*;
use cargo_test_support::str;

.with_stderr_data(str![])

(prelude is only needed for some steps)

Side note: If the test is specifically wanting to assert an empty string, use "" rather than str![] so that people are less likely to accidentally do a snapshot update to bless output that gets added.

Commit these changes

Run SNAPSHOTS=overwrite cargo test && cargo check --test testsuite. In rare cases, SNAPSHOTS=overwrite may make bad edits. Feel free to create a reproduction case and create an issue. They are usually obvious how to fix, so don't worry.

Diff the snapshots. Is there anything machine or run specific in them that previously was elided out with [..]?

Can you auto-redact it like 5ea1c8f? If so, revert the snapshot updates, add the auto-redaction (as a separate commit before any test changes), and re-run the snapshots
Otherwise, replace it with [..]

Once its working, amend your commit with the snapshots

4. Resolve non-literal deprecations

Like Step 3, but not just with_stdout("...") but with variables or format!.

Evaluate whether a literal could be used

Is the variable important for showing that output remains unchanged between instances, then keep it
Are we specifically testing for what we are using format! for, then keep it
- If not, see if it can be expressed with an auto-redaction

So this can end up with either

with_std*_data(expression)
with_std*_data(str![]) like in Step 3

5. Repeat with "straight forward" deprecations

with_stdout_unordered(expected) -> with_stdout_data(expected.unordered())
with_stderr_unordered(expected) -> with_stderr_data(expected.unordered())
with_json(expected) -> with_stdout_data(expected.json_lines()) or with_stdout_data(expected.json())
- May also require .unordered()

6. Contains / Does not Contains deprecations

A judgement needs to be made for how to handle these.

A contains can be modeled by surrounding a entry with ... (text) or "...", (json lines). The question is whether we should still do this or use a different method.

If replacing a contains with an equality check, use multi-line globs (...) for rustc errors that weren't previously matched to minimize tying Cargo's tests to the exact output of rustc
Multiple contains can be merged into a single eq with .. interspersed (or one ... and .unordered()). For example, see 3054936
- When using unordered, likely string literals, rather than str![] should be used, as these can't correctly be updated

A does_not_contain/line_without cannot be modeled at this time. The challenge with these is that they are brittle and you can't tell when they are no longer testing for what you think because the output changed. We should evaluate what to do with these on a case-by-case basis.

When in doubt, feel free to put #[allow(deprecated)] on a statement and move on. We can come back to these later.

The text was updated successfully, but these errors were encountered:

weihanglo · 2024-06-10T17:59:31Z

Porting progress

tests/testsuite/advanced_env.rs tests: Migrate alt_registry to snapbox #14031
tests/testsuite/alt_registry.rs tests: Migrate alt_registry to snapbox #14031
tests/testsuite/artifact_dep.rs Migrate a few test files to snapbox #14048
tests/testsuite/artifact_dir.rs Migrate a few test files to snapbox #14048
tests/testsuite/bad_config.rs Migrate a few test files to snapbox #14048
tests/testsuite/bad_manifest_path.rs Migrate a few test files to snapbox #14048
tests/testsuite/bench.rs Migrate a few test files to snapbox #14048
tests/testsuite/binary_name.rs test: migrate binary_name to snapbox #14041
tests/testsuite/build.rs test: migrate build to snapbox #14068
tests/testsuite/build_plan.rs test: migrate build_plan and build_script to snapbox #14193
tests/testsuite/build_script.rs test: migrate build_plan and build_script to snapbox #14193
tests/testsuite/build_script_env.rs test: migrate build_script_env to snapbox #14044
tests/testsuite/build_script_extra_link_arg.rs test: Migrate some files to snapbox #14069
tests/testsuite/cache_lock.rs test: Migrate some files to snapbox #14069
tests/testsuite/cache_messages.rs test: Migrate some files to snapbox #14069
tests/testsuite/cargo_alias_config.rs test: migrate cargo_alias_config&cargo_config/mod to snapbox #14093
tests/testsuite/cargo_command.rs test: migrate some files to snapbox #14113
tests/testsuite/cargo_config/mod.rs test: migrate cargo_alias_config&cargo_config/mod to snapbox #14093
tests/testsuite/cargo_env_config.rs test: migrate some files to snapbox #14113
tests/testsuite/cargo_features.rs test: migrate some files to snapbox #14113
tests/testsuite/cargo_targets.rs test: migrate some files to snapbox #14113
tests/testsuite/cfg.rs test: migrate cfg and check to snapbox #14185
tests/testsuite/check.rs test: migrate cfg and check to snapbox #14185
tests/testsuite/check_cfg.rs test: migrate check_cfg to snapbox #14235
tests/testsuite/clean.rs test: migrate clean to snapbox #14096
tests/testsuite/collisions.rs test: Migrate tests/testsuite/co*.rs to snapbox #14079
tests/testsuite/concurrent.rs test: Migrate tests/testsuite/co*.rs to snapbox #14079
tests/testsuite/config.rs test: Migrate tests/testsuite/co*.rs to snapbox #14079
tests/testsuite/config_cli.rs test: Migrate tests/testsuite/co*.rs to snapbox #14079
tests/testsuite/config_include.rs test: Migrate tests/testsuite/co*.rs to snapbox #14079
tests/testsuite/corrupt_git.rs test: Migrate tests/testsuite/co*.rs to snapbox #14079
tests/testsuite/credential_process.rs #test: Migrate some files to snapbox #14132
tests/testsuite/cross_compile.rs test: Migrate some files to snapbox #14132
tests/testsuite/cross_publish.rs test: Migrate some files to snapbox #14132
tests/testsuite/custom_target.rs test: Migrate some files to snapbox #14132
tests/testsuite/death.rs test: migrate testsuites to snapbox #14091
tests/testsuite/dep_info.rs @heisen-li
tests/testsuite/diagnostics.rs @heisen-li
tests/testsuite/direct_minimal_versions.rs @heisen-li
tests/testsuite/directory.rs test：migrate doc/directory/docscrape to snapbox #14171
tests/testsuite/doc.rs test：migrate doc/directory/docscrape to snapbox #14171
tests/testsuite/docscrape.rs test：migrate doc/directory/docscrape to snapbox #14171
tests/testsuite/edition.rs test：migrate edition/error to snapbox #14175
tests/testsuite/error.rs test：migrate edition/error to snapbox #14175
tests/testsuite/features.rs test: migrate features and features(2|_namespaced) to snapbox #14100
tests/testsuite/features2.rs test: migrate features and features(2|_namespaced) to snapbox #14100
tests/testsuite/features_namespaced.rs test: migrate features and features(2|_namespaced) to snapbox #14100
tests/testsuite/fetch.rs test: migrate fetch and list_availables to snapbox #14214
tests/testsuite/fix.rs test: mirgate fix* and future_incompat_report to snapbox #14173
tests/testsuite/fix_n_times.rs test: mirgate fix* and future_incompat_report to snapbox #14173
tests/testsuite/freshness.rs test: Auto-redact ... after last build at ...; Migrate freshness to Snapbox #14161
tests/testsuite/future_incompat_report.rs test: mirgate fix* and future_incompat_report to snapbox #14173
tests/testsuite/generate_lockfile.rs test: migrate generate_lockfile and glob_targets to snapbox #14200
tests/testsuite/git.rs test: Migrate git to snapbox #14159
tests/testsuite/git_auth.rs test: Migrate git_auth to snapbox #14172
tests/testsuite/git_gc.rs test: migrate git_(gc|shallow) to snapbox #14087
tests/testsuite/git_shallow.rs test: migrate git_(gc|shallow) to snapbox #14087
tests/testsuite/glob_targets.rs test: migrate generate_lockfile and glob_targets to snapbox #14200
tests/testsuite/global_cache_tracker.rs
tests/testsuite/help.rs test: migrate help to snapbox #14060
tests/testsuite/https.rs test: Migrate network tests to snapbox #14187
tests/testsuite/inheritable_workspace_fields.rs test: migrate install* and inheritable_workspace_fields to snapbox #14170
tests/testsuite/install.rs test: migrate install* and inheritable_workspace_fields to snapbox #14170
tests/testsuite/install_upgrade.rs test: migrate install* and inheritable_workspace_fields to snapbox #14170
tests/testsuite/jobserver.rs test: Migrate jobserver to snapbox #14191
tests/testsuite/lints/implicit_features.rs
tests/testsuite/lints/mod.rs test: migrate lints_table and lints/(mod|unknown_lints) to snapbox #14104
tests/testsuite/lints/unknown_lints.rs test: migrate lints_table and lints/(mod|unknown_lints) to snapbox #14104
tests/testsuite/lints/unused_optional_dependencies.rs fix: improve message for inactive weak optional feature with edition2024 through unused dep collection #14026
tests/testsuite/lints_table.rs test: migrate lints_table and lints/(mod|unknown_lints) to snapbox #14104
tests/testsuite/list_availables.rs test: migrate fetch and list_availables to snapbox #14214
tests/testsuite/local_registry.rs test: migrate some files to snapbox #14158
tests/testsuite/locate_project.rs test: migrate some files to snapbox #14158
tests/testsuite/lockfile_compat.rs test: migrate some files to snapbox #14158
tests/testsuite/login.rs test: migrate some files to snapbox #14158
tests/testsuite/logout.rs test: migrate some files to snapbox #14158
tests/testsuite/lto.rs test: Migrate lto tests to snapbox #14209
tests/testsuite/member_discovery.rs test: migrate timings_works to snapbox #14082
tests/testsuite/member_errors.rs test: migrate member_errors, multitarget and new to snapbox #14210
tests/testsuite/message_format.rs test: migrate testsuites to snapbox #14091
tests/testsuite/messages.rs
tests/testsuite/metabuild.rs test: migrate metabuild, metadata and net_config to snapbox #14162
tests/testsuite/metadata.rs test: migrate metabuild, metadata and net_config to snapbox #14162
tests/testsuite/minimal_versions.rs test: migrate minimal_versions to snapbox #14080
tests/testsuite/multitarget.rs test: migrate member_errors, multitarget and new to snapbox #14210
tests/testsuite/net_config.rs test: migrate metabuild, metadata and net_config to snapbox #14162
tests/testsuite/new.rs test: migrate member_errors, multitarget and new to snapbox #14210
tests/testsuite/offline.rs test: migrate offline, open_namespaces and owner to snapbox #14138
tests/testsuite/old_cargos.rs
tests/testsuite/open_namespaces.rs test: migrate offline, open_namespaces and owner to snapbox #14138
tests/testsuite/owner.rs test: migrate offline, open_namespaces and owner to snapbox #14138
tests/testsuite/package.rs test: migrate package* and publish* to snapbox #14130
tests/testsuite/package_features.rs test: migrate package* and publish* to snapbox #14130
tests/testsuite/patch.rs test: migrate patch, pkgid, proc_macro and progress to snapbox #14181
tests/testsuite/path.rs test: migrate path and paths to snapbox #14109
tests/testsuite/paths.rs test: migrate path and paths to snapbox #14109
tests/testsuite/pkgid.rs test: migrate patch, pkgid, proc_macro and progress to snapbox #14181
tests/testsuite/precise_pre_release.rs test: migrate testsuites to snapbox #14091
tests/testsuite/proc_macro.rs test: migrate patch, pkgid, proc_macro and progress to snapbox #14181
tests/testsuite/profile_config.rs test: migrate profile* to snapbox #14128
tests/testsuite/profile_custom.rs test: migrate profile* to snapbox #14128
tests/testsuite/profile_overrides.rs test: migrate profile* to snapbox #14128
tests/testsuite/profile_targets.rs test: migrate profile* to snapbox #14128
tests/testsuite/profile_trim_paths.rs test: migrate profile* to snapbox #14128
tests/testsuite/profiles.rs test: migrate profile* to snapbox #14128
tests/testsuite/progress.rs test: migrate patch, pkgid, proc_macro and progress to snapbox #14181
tests/testsuite/pub_priv.rs test: Migrate pub_priv.rs to snapshot #14103
tests/testsuite/publish.rs test: migrate package* and publish* to snapbox #14130
tests/testsuite/publish_lockfile.rs test: migrate package* and publish* to snapbox #14130
tests/testsuite/read_manifest.rs test: migrate serveral files to snapbox #14180
tests/testsuite/registry.rs test: migrate registry and registry_auth to snapbox #14149
tests/testsuite/registry_auth.rs test: migrate registry and registry_auth to snapbox #14149
tests/testsuite/rename_deps.rs test: migrate rename_deps, replace, required_features and run to snapbox #14127
tests/testsuite/replace.rs test: migrate rename_deps, replace, required_features and run to snapbox #14127
tests/testsuite/required_features.rs test: migrate rename_deps, replace, required_features and run to snapbox #14127
tests/testsuite/run.rs test: migrate rename_deps, replace, required_features and run to snapbox #14127
tests/testsuite/rust_version.rs test: migrate rust_version and rustc* to snapbox #14177
tests/testsuite/rustc.rs test: migrate rust_version and rustc* to snapbox #14177
tests/testsuite/rustc_info_cache.rs test: migrate rust_version and rustc* to snapbox #14177
tests/testsuite/rustdoc.rs test: migrate rustdoc and rustdocflags to snapbox #14098
tests/testsuite/rustdoc_extern_html.rs test: migrate serveral files to snapbox #14180
tests/testsuite/rustdocflags.rs test: migrate rustdoc and rustdocflags to snapbox #14098
tests/testsuite/rustflags.rs test: migrate rustflags, rustup and script to snapbox #14126
tests/testsuite/rustup.rs test: migrate rustflags, rustup and script to snapbox #14126
tests/testsuite/script.rs test: migrate rustflags, rustup and script to snapbox #14126
tests/testsuite/search.rs test: migrate search, source_replacement and standard_lib to snapbox #14151
tests/testsuite/shell_quoting.rs test: migrate features_are_quoted to snapbox #14051
tests/testsuite/source_replacement.rs test: migrate search, source_replacement and standard_lib to snapbox #14151
tests/testsuite/ssh.rs test: Migrate network tests to snapbox #14187
tests/testsuite/standard_lib.rs test: migrate search, source_replacement and standard_lib to snapbox #14151
tests/testsuite/test.rs
tests/testsuite/timings.rs test: migrate timings_works to snapbox #14082
tests/testsuite/tool_paths.rs test: migrate serveral files to snapbox #14180
tests/testsuite/tree.rs test: migrate tree and tree_graph_features to snapbox #14094
tests/testsuite/tree_graph_features.rs test: migrate tree and tree_graph_features to snapbox #14094
tests/testsuite/unit_graph.rs test: migrate unit_graph, update and vendor to snapbox #14119
tests/testsuite/update.rs test: migrate unit_graph, update and vendor to snapbox #14119
tests/testsuite/vendor.rs test: migrate unit_graph, update and vendor to snapbox #14119
tests/testsuite/verify_project.rs test: migrate testsuites to snapbox #14091
tests/testsuite/version.rs test: migrate testsuites to snapbox #14091
tests/testsuite/warn_on_failure.rs test: migrate serveral files to snapbox #14180
tests/testsuite/weak_dep_features.rs test: migrate weak_dep_features, workspaces and yank to snapbox #14111
tests/testsuite/workspaces.rs test: migrate weak_dep_features, workspaces and yank to snapbox #14111
tests/testsuite/yank.rs test: migrate weak_dep_features, workspaces and yank to snapbox #14111
tests/build-std/main.rs test: migrate build-std/main to snapbox #14241

epage · 2024-06-11T13:53:12Z

#14041 highlights a blocker for tests/testsuite/message_format.rs (and other jsonlines tests): snapbox can only render the output as jsonlines and not our "pretty printed" variant which can make the messages harder to read.

test: migrate build_script_env to snapbox ### What does this PR try to resolve? part of #14039.

test: migrate features_are_quoted to snapbox ### What does this PR try to resolve? Part of #14039. Migrate `tests/testsuite/shell_quoting.rs` to snapbox. ### How should we test and review this PR? N/A ### Additional information N/A

Migrate a few test files to snapbox This migrates the following files to `snapbox` - `artifact_dep` - Has a few `does_not_contain` - `artifact_dir` - `bad_config` - `bad_manifest_path` - Does not use `str!` for all tests - `bench` Note: This also adds auto-redactions for: - `[HOST_TARGET]` - `[ALT_TARGET]` - Only added if cross-compilation is allowed for the target - `[AVG_ELAPSED]` - For `bench` output - `[JITTER]` - For `bench` output Part of #14039

Part of rust-lang#14039

test: Migrate tests/testsuite/co*.rs to snapbox Migrating files: - tests/testsuite/collisions.rs - `with_stderr_does_not_contain` in test `collision_doc_host_target_feature_split` - tests/testsuite/concurrent.rs - tests/testsuite/config.rs - tests/testsuite/config_cli.rs - tests/testsuite/config_include.rs - tests/testsuite/corrupt_git.rs Testing with command `SNAPSHOTS=overwrite cargo test collisions::` or so. Part of #14039

test: Migrate network tests to snapbox Part of #14039.

test: migrate install* and inheritable_workspace_fields to snapbox ### What does this PR try to resolve? Part of #14039. Migrate following to snapbox: - `tests/testsuite/inheritable_workspace_fields.rs` - `tests/testsuite/install.rs` - `tests/testsuite/install_upgrade.rs`

test: migrate cfg and check to snapbox ### What does this PR try to resolve? Part of #14039. Migrate following to snapbox: - `tests/testsuite/cfg.rs` - `tests/testsuite/check.rs`

test: migrate build_plan and build_script to snapbox ### What does this PR try to resolve? Part of #14039. Migrate following to snapbox: - `tests/testsuite/build_plan.rs` - `tests/testsuite/build_script.rs`

test: Migrate jobserver to snapbox Part of #14039.

test: migrate patch, pkgid, proc_macro and progress to snapbox ### What does this PR try to resolve? Part of #14039. Migrate following to snapbox: - `tests/testsuite/patch.rs` - `tests/testsuite/pkgid.rs` - `tests/testsuite/proc_macro.rs` - `tests/testsuite/progress.rs`

test: migrate serveral files to snapbox ### What does this PR try to resolve? Part of #14039. Migrate following to snapbox: - `tests/testsuite/read_manifest.rs` - `tests/testsuite/rustdoc_extern_html.rs` - `tests/testsuite/tool_paths.rs` - `tests/testsuite/warn_on_failure.rs`

test: migrate metabuild, metadata and net_config to snapbox ### What does this PR try to resolve? Part of #14039. Migrate following to snapbox: - `tests/testsuite/metabuild.rs` - `tests/testsuite/metadata.rs` - `tests/testsuite/net_config.rs`

test: migrate member_errors, multitarget and new to snapbox ### What does this PR try to resolve? Part of #14039. Migrate following to snapbox: - `tests/testsuite/member_errors.rs` - `tests/testsuite/multitarget.rs` - `tests/testsuite/new.rs`

test: migrate generate_lockfile and glob_targets to snapbox ### What does this PR try to resolve? Part of #14039. Migrate following to snapbox: - `tests/testsuite/generate_lockfile.rs` - `tests/testsuite/glob_targets.rs`

test: migrate member_errors, multitarget and new to snapbox ### What does this PR try to resolve? Part of #14039. Migrate following to snapbox: - `tests/testsuite/member_errors.rs` - `tests/testsuite/multitarget.rs` - `tests/testsuite/new.rs`

test: Migrate lto tests to snapbox Part of #14039.

test: migrate test to snapbox ### What does this PR try to resolve? Part of #14039. Migrate following to snapbox: - `tests/testsuite/test.rs`

test: Migrate lto tests to snapbox Part of #14039.

test: migrate check_cfg to snapbox ### What does this PR try to resolve? Part of #14039. Migrate following to snapbox: - `tests/testsuite/check_cfg.rs` --- This commit allow deprecation for most of the tests currently in this file. This is because the tests either use `does_not_contain` or perform multiple `contains` assertion for single tool with macro `x!`. Here are some potential options to further eliminate the deprecation: 1. Remove the `x!` macro and replace the it with `str![]` for both Windows and non-Windows platforms. 2. Modify the `x!` macro to only generate the `--check-cfg` part for different platforms and manually compose it with `format!`.

test: migrate build-std/main to snapbox ### What does this PR try to resolve? Part of #14039. Migrate following to snapbox: - `tests/build-std/main.rs`

epage added C-enhancement Category: enhancement A-testing-cargo-itself Area: cargo's tests S-accepted Status: Issue or feature is accepted, and has a team member available to help mentor or review labels Jun 10, 2024

weihanglo mentioned this issue Jun 11, 2024

test: migrate binary_name to snapbox #14041

Merged

This comment was marked as resolved.

Sign in to view

heisen-li mentioned this issue Jun 11, 2024

test: migrate build_script_env to snapbox #14044

Merged

epage mentioned this issue Jun 11, 2024

Tests fail if directory contains special characters #14043

Closed

This comment was marked as resolved.

Sign in to view

henry40408 mentioned this issue Jun 12, 2024

test: migrate features_are_quoted to snapbox #14051

Merged

bors added a commit that referenced this issue Jun 12, 2024

Auto merge of #14044 - heisen-li:build_script_env, r=epage

c13a394

test: migrate build_script_env to snapbox ### What does this PR try to resolve? part of #14039.

epage mentioned this issue Jun 12, 2024

Migrate a few test files to snapbox #14048

Merged

This comment was marked as resolved.

Sign in to view

choznerol mentioned this issue Jun 13, 2024

test: migrate help to snapbox #14060

Merged

weihanglo mentioned this issue Jun 14, 2024

test: migrate build to snapbox #14068

Merged

heisen-li mentioned this issue Jun 14, 2024

test: Migrate some files to snapbox #14069

Merged

rami3l mentioned this issue Jun 15, 2024

chore(dist/features): ship tracing and friends by default rust-lang/rustup#3803

Merged

2 tasks

This comment has been minimized.

Sign in to view

choznerol mentioned this issue Jun 15, 2024

Remove run_expect_error to avoid tests incorrectly passing #14078

Merged

This comment has been minimized.

Sign in to view

dieterplex added a commit to dieterplex/cargo that referenced this issue Jun 15, 2024

test: Migrate tests/testsuite/co*.rs to snapbox

ba18d51

Part of rust-lang#14039

dieterplex mentioned this issue Jun 15, 2024

test: Migrate tests/testsuite/co*.rs to snapbox #14079

Merged

dieterplex added a commit to dieterplex/cargo that referenced this issue Jun 15, 2024

test: Migrate tests/testsuite/co*.rs to snapbox

037c3b8

Part of rust-lang#14039

dieterplex added a commit to dieterplex/cargo that referenced this issue Jun 15, 2024

test: Migrate tests/testsuite/co*.rs to snapbox

bd451d0

Part of rust-lang#14039

This comment was marked as resolved.

Sign in to view

henry40408 mentioned this issue Jun 16, 2024

test: migrate minimal_versions to snapbox #14080

Merged

dieterplex mentioned this issue Jul 4, 2024

test: Migrate network tests to snapbox #14187

Merged

bors added a commit that referenced this issue Jul 4, 2024

Auto merge of #14187 - dieterplex:migrate-ssh-snapbox, r=epage

3a76b8c

test: Migrate network tests to snapbox Part of #14039.

dieterplex mentioned this issue Jul 4, 2024

test: Migrate jobserver to snapbox #14191

Merged

This comment was marked as resolved.

Sign in to view

eth3lbert mentioned this issue Jul 5, 2024

test: migrate build_plan and build_script to snapbox #14193

Merged

bors added a commit that referenced this issue Jul 5, 2024

Auto merge of #14191 - dieterplex:migrate-jobserver-snapbox, r=epage

f86ce56

test: Migrate jobserver to snapbox Part of #14039.

eth3lbert mentioned this issue Jul 6, 2024

test: migrate generate_lockfile and glob_targets to snapbox #14200

Merged

dieterplex mentioned this issue Jul 8, 2024

test: Migrate lto tests to snapbox #14209

Merged

eth3lbert mentioned this issue Jul 8, 2024

test: migrate member_errors, multitarget and new to snapbox #14210

Merged

eth3lbert mentioned this issue Jul 9, 2024

test: migrate fetch and list_availables to snapbox #14214

Open

bors added a commit that referenced this issue Jul 9, 2024

Auto merge of #14209 - dieterplex:migrate-lto-snapbox, r=<try>

54fd320

test: Migrate lto tests to snapbox Part of #14039.

eth3lbert mentioned this issue Jul 10, 2024

test: migrate test to snapbox #14226

Merged

bors added a commit that referenced this issue Jul 10, 2024

Auto merge of #14226 - eth3lbert:snapbox-test, r=epage

4e19f31

test: migrate test to snapbox ### What does this PR try to resolve? Part of #14039. Migrate following to snapbox: - `tests/testsuite/test.rs`

bors added a commit that referenced this issue Jul 10, 2024

Auto merge of #14209 - dieterplex:migrate-lto-snapbox, r=weihanglo

17b52b0

test: Migrate lto tests to snapbox Part of #14039.

eth3lbert mentioned this issue Jul 10, 2024

test: migrate check_cfg to snapbox #14235

Merged

eth3lbert mentioned this issue Jul 12, 2024

test: migrate build-std/main to snapbox #14241

Merged

bors added a commit that referenced this issue Jul 12, 2024

Auto merge of #14241 - eth3lbert:snapbox-build-std, r=epage

8b1d18a

test: migrate build-std/main to snapbox ### What does this PR try to resolve? Part of #14039. Migrate following to snapbox: - `tests/build-std/main.rs`

eth3lbert mentioned this issue Jul 12, 2024

test: migrate messages to snapbox #14242

Open

epage mentioned this issue Jul 12, 2024

feat(test): Add cargo_test to test-support prelude #14243

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Port from bespoke assertions of snapbox #14039

Port from bespoke assertions of snapbox #14039

epage commented Jun 10, 2024 •

edited

Loading

weihanglo commented Jun 10, 2024 •

edited by epage

Loading

This comment was marked as resolved.

epage commented Jun 11, 2024

This comment was marked as resolved.

This comment was marked as resolved.

This comment has been minimized.

This comment has been minimized.

This comment was marked as resolved.

This comment was marked as resolved.

Port from bespoke assertions of snapbox #14039

Port from bespoke assertions of snapbox #14039

Comments

epage commented Jun 10, 2024 • edited Loading

Porting Instructions

1. Select a file to port

2. Remove #![allow(deprecated)] to identify what work is needed

3. Resolve basic deprecations

4. Resolve non-literal deprecations

5. Repeat with "straight forward" deprecations

6. Contains / Does not Contains deprecations

weihanglo commented Jun 10, 2024 • edited by epage Loading

Porting progress

This comment was marked as resolved.

epage commented Jun 11, 2024

This comment was marked as resolved.

This comment was marked as resolved.

This comment has been minimized.

This comment has been minimized.

This comment was marked as resolved.

This comment was marked as resolved.

epage commented Jun 10, 2024 •

edited

Loading

2. Remove `#![allow(deprecated)]` to identify what work is needed

weihanglo commented Jun 10, 2024 •

edited by epage

Loading