test: migrate metabuild, metadata and net_config to snapbox #14162
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
S-waiting-on-review
eth3lbert
commented
Jun 28, 2024
tests/testsuite/metadata.rs
Outdated
| .replace("$NORMAL_DEP", normal_dep) | ||
| .replace("$FOO", &foo), | ||
| ) | ||
| .unordered(), |
There was a problem hiding this comment.
Ugh, this IntoData::json(...).unordered() just isn't working as I expected. 😅
epage
reviewed
Jun 28, 2024
tests/testsuite/metadata.rs
Outdated
| .replace("$HOST_DEP", host_dep) | ||
| .replace("$NORMAL_DEP", normal_dep) | ||
| .replace("$FOO", &foo), | ||
| .replace("$ALT_TRIPLE", alt_target) |
There was a problem hiding this comment.
In theory, with snapshotting, do we need all of this manual build up?
There was a problem hiding this comment.
Yeah, I actually tried removing all the manual build parts before, but I thought that might be too aggressive. So, I decided to just carefully maintain the replacements instead.
I'll make the change.
There was a problem hiding this comment.
Updated!
There's still an ordering issue, though. Did I miss anything here?
There was a problem hiding this comment.
I went ahead and reverted the json part, allowing deprecated for now. Let's move forward!
eth3lbert
force-pushed
the
snapbox-m
branch
2 times, most recently
from
2055e5d
to
442be23
Compare
weihanglo
reviewed
Jun 28, 2024
tests/testsuite/net_config.rs
Outdated
| .with_stderr_contains("[WARNING] spurious network error (1 tries remaining): [..]") | ||
| .with_stderr_data(str![[r#" | ||
| ... | ||
| [WARNING] spurious network error (2 tries remaining): [7] Couldn't connect to server (Failed to connect to 127.0.0.1 port 11 after [..] ms: Couldn't connect to server)[..] |
There was a problem hiding this comment.
Based on my local tests, I assume it is. However, I'll redact it if it fails in CI.
weihanglo
approved these changes
Jul 7, 2024
|
Thank you. @bors r+ |
bors
added
S-waiting-on-bors
|
☀️ Test successful - checks-actions |
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jul 17, 2024
Update cargo 31 commits in 154fdac39ae9629954e19e9986fd2cf2cdd8d964..a2b58c3dad4d554ba01ed6c45c41ff85390560f2 2024-07-07 01:28:23 +0000 to 2024-07-16 00:52:02 +0000 - chore(ci): bump CI tools (rust-lang/cargo#14257) - test: migrate fetch and list_availables to snapbox (rust-lang/cargo#14214) - chore: downgrade to jobserver@0.1.28 (rust-lang/cargo#14254) - perf(source): Don't `du` on every git source load (rust-lang/cargo#14252) - fix(source): Don't warn about unreferenced duplicate packages (rust-lang/cargo#14239) - feat(test): Add cargo_test to test-support prelude (rust-lang/cargo#14243) - Add workflow to publish Cargo automatically (rust-lang/cargo#14202) - test: migrate implicit_features to snapbox (rust-lang/cargo#14245) - test: migrate build-std/main to snapbox (rust-lang/cargo#14241) - test: migrate check_cfg to snapbox (rust-lang/cargo#14235) - refactor(source): More RecursivePathSource clean up (rust-lang/cargo#14231) - Add more profiling traces (rust-lang/cargo#14238) - fix(overrides): Don't warn on duplicate packages from using '..' (rust-lang/cargo#14234) - fix(test): Redact elapsed time in the minutes time frame (rust-lang/cargo#14233) - test: Migrate lto tests to snapbox (rust-lang/cargo#14209) - fix: Ensure dep/feature activates the dependency on 2024 (rust-lang/cargo#14221) - chore(docs): update index of reference (rust-lang/cargo#14228) - test: migrate test to snapbox (rust-lang/cargo#14226) - chore: remove duplicate words (rust-lang/cargo#14229) - docs(contrib): Document things I look for in RFCs (rust-lang/cargo#14222) - docs(ref): Note MSRV for features in the docs (rust-lang/cargo#14224) - test(progress): Resolve flakiness (rust-lang/cargo#14223) - fix(test): Reduce over-prescription to the caller (rust-lang/cargo#14217) - refactor: move get_source_id out of registry (rust-lang/cargo#14218) - fix: rename to `rustdoc::broken_intra_doc_links` (rust-lang/cargo#14215) - test: migrate member_errors, multitarget and new to snapbox (rust-lang/cargo#14210) - test: migrate generate_lockfile and glob_targets to snapbox (rust-lang/cargo#14200) - test: Ensure --list test works with cargo-bloat (rust-lang/cargo#14213) - dont make new constant InternedString in hot path (rust-lang/cargo#14211) - Fix compatible_with_older_cargo test. (rust-lang/cargo#14212) - test: migrate metabuild, metadata and net_config to snapbox (rust-lang/cargo#14162)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR try to resolve?
Part of #14039.
Migrate following to snapbox:
tests/testsuite/metabuild.rstests/testsuite/metadata.rstests/testsuite/net_config.rs