Tweak the meaning of HTTP timeouts #1564
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Primarily pick up an update to curl-rust which transitively means we need to update openssl for other deps
|
r? @huonw (rust_highfive has picked a reviewer for you, use r? to override) |
|
@bors r+ |
|
📌 Commit 35b871c has been approved by |
|
⌛ Testing commit 35b871c with merge ceafa2b... |
|
💔 Test failed - cargo-win-32 |
alexcrichton
force-pushed
the
right-timeout
branch
from
35b871c
to
c81e2e5
Compare
|
⌛ Testing commit c81e2e5 with merge 83f4535... |
|
💔 Test failed - cargo-mac-64 |
alexcrichton
force-pushed
the
right-timeout
branch
from
c81e2e5
to
90097a3
Compare
|
⌛ Testing commit 90097a3 with merge 15f76b7... |
|
💔 Test failed - cargo-win-64 |
Previously a timeout was set via libcurl's blanket timeout option, which is a timeout for the entire request. This isn't always what we want, however, as cargo is used on quite a variety of networks. Instead what we really want is timing out data being received, so instead of a blanket timeout we set two different timeouts: * The connect timeout is now configured (time it takes to connect the socket) * A "low speed" timeout is now also set. This means that if Cargo doesn't receive 10 bytes of data in the specified tiemout period that the entire transfer will be timed out. Closes rust-lang#1560
alexcrichton
force-pushed
the
right-timeout
branch
from
90097a3
to
923c2f2
Compare
bors
added a commit
that referenced
this pull request
Apr 30, 2015
Previously a timeout was set via libcurl's blanket timeout option, which is a timeout for the entire request. This isn't always what we want, however, as cargo is used on quite a variety of networks. Instead what we really want is timing out data being received, so instead of a blanket timeout we set two different timeouts: * The connect timeout is now configured (time it takes to connect the socket) * A "low speed" timeout is now also set. This means that if Cargo doesn't receive 10 bytes of data in the specified tiemout period that the entire transfer will be timed out. Closes #1560
|
☀️ Test successful - cargo-linux-32, cargo-linux-64, cargo-mac-32, cargo-mac-64, cargo-win-32, cargo-win-64 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously a timeout was set via libcurl's blanket timeout option, which is a
timeout for the entire request. This isn't always what we want, however, as
cargo is used on quite a variety of networks. Instead what we really want is
timing out data being received, so instead of a blanket timeout we set two
different timeouts:
receive 10 bytes of data in the specified tiemout period that the entire
transfer will be timed out.
Closes #1560