Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix rust-lang/rust#35203 warning/error #3231

Merged
merged 1 commit into from
Oct 26, 2016
Merged

Conversation

TimNN
Copy link
Contributor

@TimNN TimNN commented Oct 26, 2016

rust-lang/rust#35203 made patterns in functions without body into a warn by default lint (which is being denyed here).

cc rust-lang/rust#37378, rust-lang/rust#37416

rust-lang/rust#35203 made patterns in functions without body into a warn by default lint (which is being `deny`ed here).
@rust-highfive
Copy link

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @brson (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@alexcrichton
Copy link
Member

@bors: r+

@bors
Copy link
Collaborator

bors commented Oct 26, 2016

📌 Commit 81dfab4 has been approved by alexcrichton

@bors
Copy link
Collaborator

bors commented Oct 26, 2016

⌛ Testing commit 81dfab4 with merge 806e3c3...

bors added a commit that referenced this pull request Oct 26, 2016
Fix rust-lang/rust#35203 warning/error

rust-lang/rust#35203 made patterns in functions without body into a warn by default lint (which is being `deny`ed here).

cc rust-lang/rust#37378, rust-lang/rust#37416
@bors
Copy link
Collaborator

bors commented Oct 26, 2016

☀️ Test successful - cargo-cross-linux, cargo-linux-32, cargo-linux-64, cargo-mac-32, cargo-mac-64, cargo-win-gnu-32, cargo-win-gnu-64, cargo-win-msvc-32, cargo-win-msvc-64
Approved by: alexcrichton
Pushing 806e3c3 to master...

@bors bors merged commit 81dfab4 into rust-lang:master Oct 26, 2016
@petrochenkov
Copy link
Contributor

@TimNN
You closed the tracking issue rust-lang/rust#35203 accidentally.

@TimNN TimNN deleted the patch-1 branch October 26, 2016 18:24
@TimNN
Copy link
Contributor Author

TimNN commented Oct 26, 2016

You closed the tracking issue rust-lang/rust#35203 accidentally.

It's open again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants