Include package props with corresponding env vars into target metadata #3857
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(rust_highfive has picked a reviewer for you, use r? to override) |
|
Looks great, thanks! Could you leave a comment over in where the env vars are set to be sure to update this hash piece as well? |
Previously, when changing package properties with corresponding environment variables (such as authors, which has CARGO_PKG_AUTHORS), it didn't invalidate the build, even though there could have been a dependency on such variables in the source code. This commit includes such properties (there are 3 of them in total: authors, description and homepage) in the target metadata. Fixes rust-lang#3696.
antonlarin
force-pushed
the
rebuild-on-env-change
branch
from
2fe29b7
to
d70ca21
Compare
|
Done. While looking for a place where hash is calculated I also have stumbled upon a misleading comment (no function |
|
Heh yeah comments don't always live up to the test of time... In any case looks great, thanks again! @bors: r+ |
|
📌 Commit d70ca21 has been approved by |
bors
added a commit
that referenced
this pull request
Mar 23, 2017
Include package props with corresponding env vars into target metadata Previously, when changing package properties with corresponding environment variables (such as authors, which has CARGO_PKG_AUTHORS), it didn't invalidate the build, even though there could have been a dependency on such variables in the source code. This commit includes 3 such properties: authors list, description and homepage in the target metadata. I've added a test only for description change, can add more if necessary. Fixes #3696.
|
☀️ Test successful - status-appveyor, status-travis |
bors
added a commit
that referenced
this pull request
Mar 26, 2019
Some fingerprint cleanup. Just a minor cleanup. Move `CARGO_PKG_*` values from Metadata to Fingerprint (added in #3857). Closes #6208. This prevents stale artifacts from being left behind when these values change. Also tracks changes to the "repository" value (added in #6096). Remove `edition` as a separate field. It is already tracked in `target`. This was required previously to #5816 which added per-target editions. Also adds a helper to the testsuite to make globbing easier.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, when changing package properties with corresponding environment variables (such as authors, which has CARGO_PKG_AUTHORS), it didn't invalidate the build, even though there could have been a dependency on such variables in the source code.
This commit includes 3 such properties: authors list, description and homepage in the target metadata.
I've added a test only for description change, can add more if necessary.
Fixes #3696.