Revert "Warn Windows 7 users about old TLS" #5097
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We now have upgraded libgit2 version, so Cargo would use TLS 1.2 on windows unconditionally. Note that even *unpatched* windows 7 supports TLS 1.2
|
(rust_highfive has picked a reviewer for you, use r? to override) |
|
@bors: r+ |
|
📌 Commit 7458491 has been approved by |
bors
added a commit
that referenced
this pull request
Feb 28, 2018
Revert "Warn Windows 7 users about old TLS" We now have upgraded libgit2 version, so Cargo would use TLS 1.2 on windows unconditionally. Note that even *unpatched* windows 7 supports TLS 1.2. @retep998, you've originally written that >TLS 1.2 support for Windows 7 still requires a rather recent patch and so even if we do fix that, we should still keep this error message because some people use Windows 7 with automatic updates disabled. However, it looks like Windows 7 **does** support TLS 1.2 out of the box, and the update is required to enable the use of TLS 1.2 by default: libgit2/libgit2#4546 (comment) My own testing on a random win 7 virtual box confirms this. closes #5066
|
☀️ Test successful - status-appveyor, status-travis |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We now have upgraded libgit2 version, so Cargo would use TLS 1.2
on windows unconditionally. Note that even unpatched windows 7
supports TLS 1.2.
@retep998, you've originally written that
However, it looks like Windows 7 does support TLS 1.2 out of the box, and the update is required to enable the use of TLS 1.2 by default:
libgit2/libgit2#4546 (comment)
My own testing on a random win 7 virtual box confirms this.
closes #5066