Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

crate download: don't print that a crate was the largest download if it was the only download #6916

Merged
merged 2 commits into from May 8, 2019

Conversation

Projects
None yet
4 participants
@matthiaskrgr
Copy link
Contributor

commented May 7, 2019

before:

    Updating crates.io index
  Downloaded procs v0.8.4
  Downloaded 1 crates (1.1 MB) in 2.90s (largest was `procs` at 1.1 MB)
  Installing procs v0.8.4

after:

    Updating crates.io index
  Downloaded procs v0.8.4
  Downloaded 1 crates (1.1 MB) in 1.50s
  Installing procs v0.8.4
@rust-highfive

This comment has been minimized.

Copy link

commented May 7, 2019

r? @alexcrichton

(rust_highfive has picked a reviewer for you, use r? to override)

@matthiaskrgr matthiaskrgr changed the title crate download: don't print that a crate was the largets download if it was the only download crate download: don't print that a crate was the largest download if it was the only download May 7, 2019

crate download: don't print that a crate was the largest download if …
…it was the only download

before:

    Updating crates.io index
  Downloaded procs v0.8.4
  Downloaded 1 crates (1.1 MB) in 2.90s (largest was `procs` at 1.1 MB)
  Installing procs v0.8.4

after:

    Updating crates.io index
  Downloaded procs v0.8.4
  Downloaded 1 crates (1.1 MB) in 1.50s
  Installing procs v0.8.4

@matthiaskrgr matthiaskrgr force-pushed the matthiaskrgr:single_largest branch from e5b537b to a7d7821 May 7, 2019

@alexcrichton

This comment has been minimized.

Copy link
Member

commented May 8, 2019

@bors: r+

@bors

This comment has been minimized.

Copy link
Contributor

commented May 8, 2019

📌 Commit a7d7821 has been approved by alexcrichton

@bors

This comment has been minimized.

Copy link
Contributor

commented May 8, 2019

⌛️ Testing commit a7d7821 with merge 345d570...

bors added a commit that referenced this pull request May 8, 2019

Auto merge of #6916 - matthiaskrgr:single_largest, r=alexcrichton
crate download: don't print that a crate was the largest download if it was the only download

    before:

        Updating crates.io index
      Downloaded procs v0.8.4
      Downloaded 1 crates (1.1 MB) in 2.90s (largest was `procs` at 1.1 MB)
      Installing procs v0.8.4

    after:

        Updating crates.io index
      Downloaded procs v0.8.4
      Downloaded 1 crates (1.1 MB) in 1.50s
      Installing procs v0.8.4
@bors

This comment has been minimized.

Copy link
Contributor

commented May 8, 2019

☀️ Test successful - checks-travis, status-appveyor
Approved by: alexcrichton
Pushing 345d570 to master...

@bors bors merged commit a7d7821 into rust-lang:master May 8, 2019

3 checks passed

Travis CI - Pull Request Build Passed
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
homu Test successful
Details

@ehuss ehuss referenced this pull request May 16, 2019

Merged

Update cargo #60874

bors added a commit to rust-lang/rust that referenced this pull request May 16, 2019

Auto merge of #60874 - ehuss:update-cargo, r=alexcrichton
Update cargo

17 commits in 759b6161a328db1d4863139e90875308ecd25a75..c4fcfb725b4be00c72eb9cf30c7d8b095577c280
2019-05-06 20:47:49 +0000 to 2019-05-15 19:48:47 +0000
- tests: registry: revert readonly permission after running tests. (rust-lang/cargo#6947)
- Remove Candidate (rust-lang/cargo#6946)
- Fix for "Running cargo update without a Cargo.lock ignores arguments" rust-lang/cargo#6872 (rust-lang/cargo#6904)
- Fix a minor mistake in the changelog. (rust-lang/cargo#6944)
- Give a better error message when crates.io requests time out (rust-lang/cargo#6936)
- Re-enable compatibility with readonly CARGO_HOME (rust-lang/cargo#6940)
- Fix version of `ignore`. (rust-lang/cargo#6938)
- Stabilize offline mode. (rust-lang/cargo#6934)
- zsh: Add doc options to include non-public items documentation (rust-lang/cargo#6929)
- zsh: Suggest --lib option as binary template now the default (rust-lang/cargo#6926)
- Migrate package include/exclude to gitignore patterns. (rust-lang/cargo#6924)
- Implement the Cargo half of pipelined compilation (take 2) (rust-lang/cargo#6883)
- Always include `Cargo.toml` when packaging. (rust-lang/cargo#6925)
- Remove unnecessary calls to masquerade_as_nightly_cargo. (rust-lang/cargo#6923)
- download: fix "Downloaded 1 crates" message (crates -> crate) (rust-lang/cargo#6920)
- Changed RUST_LOG usage to CARGO_LOG to avoid confusion. (rust-lang/cargo#6918)
- crate download: don't print that a crate was the largest download if it was the only download (rust-lang/cargo#6916)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.