Document that package can be used in [patch]
#7263
Conversation
|
r? @ehuss (rust_highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
|
Heh, I stumbled on an issue (#7264). I'm thinking it might be helpful to add a note expanding on this a little, since I don't think it is obvious how this works. I think there are two points to make:
(Not sure how to say these two things succinctly and clearly.) The second point is complex. I would like to at some point add an entire chapter on how version resolution works. When we do that, we can maybe include a dedicated sub-section on how Some of the complexities I'm thinking of are:
|
|
@Hoverbear I think you're running into #5478, although it may be manifesting as a panic. I suspect if the panic is fixed then it still won't work due to #5478. @ehuss excellent points! I think you're definitely right in that we're about 4 years late for having a section on how the resolver works in the documentation. I'll think on this and see if I can figure out a better set of words to include. |
|
@alexcrichton Ha! Seems this leads down the rabbit hole to #6921 and #5471 :-P |
This works to `[patch]` multiple versions of a crate, and turns out this has worked since the inception of `package`! Closes rust-lang#6169
alexcrichton
force-pushed
the
multipass
branch
from
0826bea
to
2a391a7
Compare
|
Er I messed up git and didn't actually push, pushed now. |
|
@bors r+ |
|
📌 Commit 2a391a7 has been approved by |
bors
added
S-waiting-on-bors
Document that `package` can be used in `[patch]` This works to `[patch]` multiple versions of a crate, and turns out this has worked since the inception of `package`! Closes #6169
|
☀️ Test successful - checks-azure |
Update cargo Update cargo 10 commits in 3f700ec43ce72305eb5315cfc710681f3469d4b4..22f7dd0495cd72ce2082d318d5a9b4dccb9c5b8c 2019-08-19 22:43:12 +0000 to 2019-08-27 16:10:51 +0000 - Update and improve zsh completion (rust-lang/cargo#7296) - Document that `package` can be used in `[patch]` (rust-lang/cargo#7263) - Fix `error:`/`warning:` coloring inconsistency with rustc (rust-lang/cargo#7294) - Tests: Import rustc_plugin from its new location (rust-lang/cargo#7287) - Update README azure badge. (rust-lang/cargo#7293) - Update home dependencies to v0.5 (rust-lang/cargo#7277) - Fix typo (rust-lang/cargo#7279) - Update libgit2 dependencies (rust-lang/cargo#7275) - Fix old lockfile encoding wrt newlines (rust-lang/cargo#7262) - Fix dSYM uplifting when symlink is broken (rust-lang/cargo#7268)
This works to
[patch]multiple versions of a crate, and turns out thishas worked since the inception of
package!Closes #6169