Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix `error:`/`warning:` coloring inconsistency with rustc #7294

Merged
merged 1 commit into from Aug 26, 2019

Conversation

@SnejUgal
Copy link
Contributor

commented Aug 24, 2019

When rustc prints an error, the word error is red, but the colon after it is white (and the same goes for warn, note and other messages). cargo, however, colors the colon as well, and it looks inconsistent when rustc's output is followed by cargo's side-by-side. If cargo prints the colon in white, the output looks more accurate.

@rust-highfive

This comment has been minimized.

Copy link

commented Aug 24, 2019

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @ehuss (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@alexcrichton

This comment has been minimized.

Copy link
Member

commented Aug 26, 2019

@bors: r+

Thanks!

@bors

This comment has been minimized.

Copy link
Contributor

commented Aug 26, 2019

📌 Commit dd653eb has been approved by alexcrichton

@bors

This comment has been minimized.

Copy link
Contributor

commented Aug 26, 2019

⌛️ Testing commit dd653eb with merge 732cc52...

bors added a commit that referenced this pull request Aug 26, 2019
Auto merge of #7294 - SnejUgal:fix-inconsistent-coloring, r=alexcrichton
Fix `error:`/`warning:` coloring inconsistency with rustc

When `rustc` prints an error, the word `error` is red, but the colon after it is white (and the same goes for `warn`, `note` and other messages). `cargo`, however, colors the colon as well, and it [looks inconsistent](https://user-images.githubusercontent.com/10610844/63640674-45040f00-c6cd-11e9-9ee9-6f6f44a51f83.png) when `rustc`'s output is followed by `cargo`'s side-by-side. If `cargo` prints the colon in white, the output [looks more accurate](https://user-images.githubusercontent.com/10610844/63640792-f2c3ed80-c6ce-11e9-9b6e-ba209a4f9788.png).
@bors

This comment has been minimized.

Copy link
Contributor

commented Aug 26, 2019

☀️ Test successful - checks-azure
Approved by: alexcrichton
Pushing 732cc52 to master...

@bors bors merged commit dd653eb into rust-lang:master Aug 26, 2019

10 checks passed

homu Test successful
Details
rust-lang.cargo Build #20190824.4 succeeded
Details
rust-lang.cargo (Linux beta) Linux beta succeeded
Details
rust-lang.cargo (Linux nightly) Linux nightly succeeded
Details
rust-lang.cargo (Linux stable) Linux stable succeeded
Details
rust-lang.cargo (Windows x86_64-msvc) Windows x86_64-msvc succeeded
Details
rust-lang.cargo (docs) docs succeeded
Details
rust-lang.cargo (macOS) macOS succeeded
Details
rust-lang.cargo (resolver) resolver succeeded
Details
rust-lang.cargo (rustfmt) rustfmt succeeded
Details

@SnejUgal SnejUgal deleted the SnejUgal:fix-inconsistent-coloring branch Aug 27, 2019

@ehuss ehuss referenced this pull request Aug 27, 2019
bors added a commit to rust-lang/rust that referenced this pull request Aug 27, 2019
Auto merge of #63960 - ehuss:update-cargo, r=alexcrichton
Update cargo

Update cargo

10 commits in 3f700ec43ce72305eb5315cfc710681f3469d4b4..22f7dd0495cd72ce2082d318d5a9b4dccb9c5b8c
2019-08-19 22:43:12 +0000 to 2019-08-27 16:10:51 +0000
- Update and improve zsh completion (rust-lang/cargo#7296)
- Document that `package` can be used in `[patch]` (rust-lang/cargo#7263)
- Fix `error:`/`warning:` coloring inconsistency with rustc (rust-lang/cargo#7294)
- Tests: Import rustc_plugin from its new location (rust-lang/cargo#7287)
- Update README azure badge. (rust-lang/cargo#7293)
- Update home dependencies to v0.5 (rust-lang/cargo#7277)
- Fix typo (rust-lang/cargo#7279)
- Update libgit2 dependencies (rust-lang/cargo#7275)
- Fix old lockfile encoding wrt newlines (rust-lang/cargo#7262)
- Fix dSYM uplifting when symlink is broken (rust-lang/cargo#7268)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.