vendor: don't use canonical path in .cargo/config #7629
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @Eh2406 (rust_highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
jsgf
changed the title
Use the user-specified path as-is, so it remains relative if specified as relative. Should also address Windows path canonicalization issues. Resolves issue rust-lang#7316
|
One open question is whether to replicate the behaviour of |
|
Test failures seem spurious. |
|
vendor... so |
|
@bors: r+ |
|
📌 Commit 4c67a2d has been approved by |
bors
added
S-waiting-on-bors
|
⌛ Testing commit 4c67a2d with merge 188b718a2fca68bb75b287feae3e6a38547d7d39... |
|
@bors: retry gonna get the nightly fix in first |
|
⌛ Testing commit 4c67a2d with merge 5066168fa2dc785786089e840df99b27b1563c1b... |
|
@bors: retry got the queue priority wrong |
bors
added a commit
that referenced
this pull request
Nov 25, 2019
vendor: don't use canonical path in .cargo/config Use the user-specified path as-is, so it remains relative if specified as relative. Should also address Windows path canonicalization issues. Resolves issue #7316
|
☀️ Test successful - checks-azure |
bors
added a commit
to rust-lang/rust
that referenced
this pull request
Dec 4, 2019
Update cargo 11 commits in 750cb1482e4d0e74822cded7ab8b3c677ed8b041..626f0f40efd32e6b3dbade50cd53fdfaa08446ba 2019-11-23 23:06:36 +0000 to 2019-12-03 16:53:04 +0000 - Change some texts to links in README (rust-lang/cargo#7652) - Update config and environment variable docs. (rust-lang/cargo#7650) - Stop ignoring .rs.bk files; rustfmt hasn't generated them in years (rust-lang/cargo#7647) - Various contributing docs updates. (rust-lang/cargo#7642) - Stabilize profile-overrides. (rust-lang/cargo#7591) - Update comment about ResolveVersion default version. (rust-lang/cargo#7637) - Update tests for slight wording change in rustdoc error message. (rust-lang/cargo#7641) - Remove dep_targets. (rust-lang/cargo#7626) - vendor: don't use canonical path in .cargo/config (rust-lang/cargo#7629) - Minor testsuite organization. (rust-lang/cargo#7628) - Remove failing plugin tests. (rust-lang/cargo#7630)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use the user-specified path as-is, so it remains relative if specified as relative.
Should also address Windows path canonicalization issues.
Resolves issue #7316