Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version 1.0.95 breaks cross compilation #1039

Closed
ofek opened this issue Apr 20, 2024 · 7 comments
Closed

Version 1.0.95 breaks cross compilation #1039

ofek opened this issue Apr 20, 2024 · 7 comments

Comments

@ofek
Copy link

ofek commented Apr 20, 2024

The issue appears to be this commit: 9af6b95

I discovered this when trying to build this repo: https://github.com/ofek/pyapp

Passed 6 hours ago: https://github.com/pypa/hatch/actions/runs/8760646787/job/24045960846#step:12:121

Now consistently failing: https://github.com/pypa/hatch/actions/runs/8762826835/job/24051033022?pr=1407#step:12:124

@NobodyXu
Copy link
Collaborator

Hmmm I think it's one of the old glibc, which doesn't have the preadv2 symbol.

I would open a PR in upstream jobserver-rs for this.

@groovybits
Copy link

See my issue #1040 it breaks cargo-c too, same issue it seems.

@NobodyXu
Copy link
Collaborator

Opened an issue in jobserver, it will be fixed in upstream rust-lang/jobserver-rs#87

@ofek
Copy link
Author

ofek commented Apr 20, 2024

Can you explain the issue a bit more please because I don't quite understand why the issue is in the other library when it was the new release of this package that started causing issues.

weihanglo added a commit to weihanglo/jobserver-rs that referenced this issue Apr 20, 2024
This optimization has introduced many compatibility issues,
so remove it for now until we find it worthy the investment.

See also

* <rust-lang/cc-rs#1039>
* <rust-lang#87>
@NobodyXu
Copy link
Collaborator

The preadv2 syscall is used by jobserver-rs as an optimization, cc-rs does not call preadv2 directly.

Sorry if I was being rude, I wrote that jobserver optimization myself so my first reaction is this is from jobserver, which is probably confusing for you.

@ofek
Copy link
Author

ofek commented Apr 20, 2024

Oh that makes much more sense now, thank you! I will close this.

@ofek ofek closed this as completed Apr 20, 2024
petrochenkov pushed a commit to rust-lang/jobserver-rs that referenced this issue Apr 20, 2024
This optimization has introduced many compatibility issues,
so remove it for now until we find it worthy the investment.

See also

* <rust-lang/cc-rs#1039>
* <#87>
@NobodyXu
Copy link
Collaborator

Thank you very much for reporting, it seems upstream already merged the PR fixing this (by removing use of preadv2 for now) and would cut a new release soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants