fix: remove preadv2 optimization #88
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This optimization has introduced many compatibility issues, so remove it for now until we find it worthy the investment. See also * <rust-lang/cc-rs#1039> * <rust-lang#87>
|
You can use |
|
Thanks! That sounds also correct, though I personally don't have time investing in it (also have less experience of that). Need somebody else to work on that route. |
|
If it's not a one or two line change then I agree that we should revert for now to fix builds. I would be interested in the syscall change however because that seems simple but I'm not familiar with the code base. |
|
When might this be released? |
|
I've asked @petrochenkov to do so on zulip, only they have the right to publish a new release |
1 task
joseluisq
added a commit
to static-web-server/static-web-server
that referenced
this pull request
Apr 21, 2024
due to builds issues as reported on rust-lang/jobserver-rs#87 this workaround can be removed once rust-lang/jobserver-rs#88 is released
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This optimization has introduced many compatibility issues, so remove it for now until we find it worthy the investment.
See also