Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify crate structure #215

Merged
merged 7 commits into from Apr 19, 2019

Conversation

Projects
None yet
3 participants
@detrumi
Copy link
Contributor

commented Apr 17, 2019

Implements changes described in #214

@nikomatsakis
Copy link
Collaborator

left a comment

Everything looks great so far!

@detrumi detrumi force-pushed the detrumi:simplify-crate-structure branch from d93e8f3 to 6579260 Apr 18, 2019

Show resolved Hide resolved chalk-solve/src/coherence/orphan.rs Outdated
Show resolved Hide resolved chalk-solve/src/wf.rs
Show resolved Hide resolved chalk-solve/src/coherence.rs
@detrumi

This comment has been minimized.

Copy link
Contributor Author

commented Apr 19, 2019

Leaving the SolverChoice parameters as is, as the functions would require mutability otherwise. I was planning to update crates.md with the changes, but let's wait until ChalkSolveDatabase can be removed once program_clauses_that_could_match is replaced.

@detrumi detrumi marked this pull request as ready for review Apr 19, 2019

@nikomatsakis
Copy link
Collaborator

left a comment

👍

Show resolved Hide resolved chalk-solve/src/coherence/orphan.rs Outdated
Add missing dyn
Co-Authored-By: detrumi <Wilcokusee@gmail.com>

@nikomatsakis nikomatsakis merged commit 6fd1808 into rust-lang:master Apr 19, 2019

1 check failed

Travis CI - Pull Request Build Failed
Details

@detrumi detrumi deleted the detrumi:simplify-crate-structure branch Apr 19, 2019

@igaray igaray referenced this pull request Apr 25, 2019

Merged

Broken chalk links #307

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.