Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify crate structure #215

Merged
merged 7 commits into from Apr 19, 2019
Merged

Simplify crate structure #215

merged 7 commits into from Apr 19, 2019

Conversation

detrumi
Copy link
Member

@detrumi detrumi commented Apr 17, 2019

Implements changes described in #214

nikomatsakis
nikomatsakis approved these changes Apr 17, 2019
View reviewed changes
Copy link
Contributor

@nikomatsakis nikomatsakis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks great so far!

nikomatsakis
nikomatsakis requested changes Apr 18, 2019
View reviewed changes
chalk-solve/src/coherence/orphan.rs Outdated Show resolved Hide resolved
chalk-solve/src/wf.rs Show resolved Hide resolved
chalk-solve/src/coherence.rs Show resolved Hide resolved
@detrumi
Copy link
Member Author

detrumi commented Apr 19, 2019 •
edited

Leaving the SolverChoice parameters as is, as the functions would require mutability otherwise. I was planning to update crates.md with the changes, but let's wait until ChalkSolveDatabase can be removed once program_clauses_that_could_match is replaced.

@detrumi detrumi marked this pull request as ready for review April 19, 2019 12:11
nikomatsakis
nikomatsakis requested changes Apr 19, 2019
View reviewed changes
Copy link
Contributor

@nikomatsakis nikomatsakis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

chalk-solve/src/coherence/orphan.rs Outdated Show resolved Hide resolved
@nikomatsakis @detrumi
Add missing dyn
e3b7e1e 
Co-Authored-By: detrumi <Wilcokusee@gmail.com>
@nikomatsakis nikomatsakis merged commit 6fd1808 into rust-lang:master Apr 19, 2019
@detrumi detrumi deleted the simplify-crate-structure branch April 19, 2019 18:14
@igaray igaray mentioned this pull request Apr 25, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nikomatsakis nikomatsakis nikomatsakis requested changes

@matklad matklad matklad left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@detrumi @nikomatsakis @matklad