New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Broken chalk links #307
Broken chalk links #307
Conversation
I'd only put the Fix broken chalk links commit here. BTW there's a typo in that commit message |
Now looks good /cc @nikomatsakis |
Travis still failed :( |
mdbook test is the culprit this time, I didn't know about that. |
CI toolchain hasn't yet updated to the rustc version which accepts the two-phase borrows in the two-phase borrow documentation examples. |
Yes, your PR is unrelated and it's good to go. |
Thanks @igaray! The CI failures are not from this PR they are from the last PR, which added the two-phase borrows chapter. If you don’t mind fixing them, that would be appreciated greatly. Basically all of the code blocks with error messages need to be annotated to tell mdbook test that they aren’t rust code: |
@mark-i-m Roger, will do. Although the offending code https://github.com/rust-lang/rustc-guide/pull/305/files#diff-5311fe548c2eb1bbb4b4ab3ca2151676R18 does in fact compile with the latest nightly (rustc 1.36.0-nightly (e305df184 2019-04-24)) and |
Oh. I guess I confused myself and misread your comment. I'm sorry. In that case, I think we can just merge. I think the right solution is just for rustc-guide to use the nightly compiler in its CI. After all, it is describing the nightly state of the compiler... |
❤️ thanks all |
Fixed some links broken by rust-lang/chalk#215