remove IntoIterator impl for &Binders #501
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removing a redundant
IntoIterator
impl for&Binders
following this zulip convo.The reason to do this is
a) you can achieve the same effect by doing
binders.as_ref().into_iter()
b) because of the somewhat recursive nature of the definition (both
Item
andSelf
containBinders<_>
) it often results in cryptic errors if typechecking is unsuccessfull (you can check zulip convo for examples).