Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove IntoIterator impl for &Binders #501

Merged
merged 1 commit into from
Jun 8, 2020

Conversation

basil-cow
Copy link
Contributor

Removing a redundant IntoIterator impl for &Binders following this zulip convo.

The reason to do this is
a) you can achieve the same effect by doing binders.as_ref().into_iter()
b) because of the somewhat recursive nature of the definition (both Item and Self contain Binders<_>) it often results in cryptic errors if typechecking is unsuccessfull (you can check zulip convo for examples).

@jackh726 jackh726 merged commit 4dba5a5 into rust-lang:master Jun 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants