Recursive solver factoring and privacy #513
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nikomatsakis
changed the title
nikomatsakis
changed the title
In particular, the `solve_iteration` method depends only on `SolveDatabase`` (as does `Fulfill`). The expectation is that the `solve_goal` method will eventually be a callback into salsa or the host integration -- potentially this trait will merge with `RustIrDatabase`
jackh726
approved these changes
Jun 11, 2020
jackh726
reviewed
Jun 11, 2020
| } | ||
| } | ||
|
|
||
| impl<S, I> SolveIterationHelpers<I> for S |
There was a problem hiding this comment.
There are two traits -- one is the public method, the other is the private helpers, and you need an impl for both.
|
(Yes, it's just moving things around) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This branch just starts to factor the recursive solver into a few more files, and tightens up some of the privacy.
My goal was to try and better separate out the "caching and loop logic", which I hope to eventually move to salsa, from the chalk-specific logic. For now I got as far as moving most of the chalk-specific stuff into the
solvemodule.The next step is going to be trying to factor out the caching stuff into a module that is generic over chalk-specific things, but that's for another day.