Remove Context trait from chalk-engine #611
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nikomatsakis
approved these changes
Sep 29, 2020
|
This looks really good. I kinda' miss the old traits but I think concrete code will ultimately be much easier for folks to read. |
|
r=me to land @jackh726 |
I definitely understand this sentiment. It's sort of nice to have an abstraction. But I think ultimately it isn't necessary anymore and makes it harder to understand. @bors r=nikomatsakis |
|
📌 Commit 0cdc6c7 has been approved by |
|
☀️ Test successful - checks-actions |
detrumi
added a commit
to detrumi/chalk
that referenced
this pull request
Oct 4, 2020
This broke a while back in rust-lang#611, but only now broke the build because the hosted docs were updated.
bors
added a commit
that referenced
this pull request
Oct 4, 2020
Fix mdbook links after chalk-engine changes This broke a while back in #611, but only now broke the build because the hosted docs were updated. CC `@jackh726`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is unneeded now that chalk-engine knows about chalk-solve. The only reason we might want this is for abstraction, but I don't think that really gets us very far here.
There's more that could be done here, for sure. But this has been sitting locally for a while and figured it's a good enough place as any to PR.