-
Notifications
You must be signed in to change notification settings - Fork 179
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Subst canonical environment clauses #671
Conversation
Actually, there's more wrong here that the test case doesn't cover. |
Better repro:
|
Okay this is good to go now |
Ugh this still isn't completely correct. This fails when the environment with bound vars from the I don't have a min repro yet, but it occurs in the chalkify tests in rustc |
Alright so, this is kind of a difficult design problem: what are the environments in I also don't have a repro currently. |
☔ The latest upstream changes (presumably #673) made this pull request unmergeable. Please resolve the merge conflicts. |
b8b3546
to
3591cd1
Compare
3591cd1
to
acc1bfa
Compare
…ty, write out explicit rules instead of pushing a fact. Generalize others.
@bors r+ |
📌 Commit 09c9adc has been approved by |
☀️ Test successful - checks-actions |
No environment in Constraints Should have been included in #671. Oops.
Fixes #670
I'm not sure if this is the right approach. Recursive solver gets substed later because clauses get instantiated later. There's also a
clone
there which would be nice to get rid of.