-
Notifications
You must be signed in to change notification settings - Fork 179
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Generate clauses for super traits of opaque bounds #681
Conversation
I keep meaning to get to reviewing this, and have read through it a couple times. But still haven't thought completely about it. I'll try to get to it this weekend. |
@jackh726 Ping, could you do a quick review? The essence of the change is in the first commit, the rest is just moving some code around to avoid duplicating this code for both opaque types and dyn types. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A couple nits; take them or leave them
r=me either way
@bors r=jackh726 |
📌 Commit 29ba9ee has been approved by |
☀️ Test successful - checks-actions |
Implements #677
Turns out that push_dyn_ty_impl_clauses can also be used for opaque types.