Generate clauses for super traits of opaque bounds #681
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I keep meaning to get to reviewing this, and have read through it a couple times. But still haven't thought completely about it. I'll try to get to it this weekend. |
|
@jackh726 Ping, could you do a quick review? The essence of the change is in the first commit, the rest is just moving some code around to avoid duplicating this code for both opaque types and dyn types. |
jackh726
approved these changes
Feb 16, 2021
|
@bors r=jackh726 |
|
📌 Commit 29ba9ee has been approved by |
|
☀️ Test successful - checks-actions |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements #677
Turns out that push_dyn_ty_impl_clauses can also be used for opaque types.