Remove unused version_authors.user_id
#2190
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Turbo87
approved these changes
Sep 18, 2020
Turbo87
reviewed
Oct 24, 2020
src/controllers/version/metadata.rs
Outdated
| meta: Meta, | ||
| } | ||
| #[derive(Serialize)] | ||
| struct Meta { | ||
| names: Vec<String>, | ||
| } | ||
| Ok(req.json(&R { | ||
| users: vec![], |
There was a problem hiding this comment.
@JohnTitor we discussed this in the team meeting yesterday. we would prefer for this to stay in the API response for now to avoid potentially breaking changes. the database changes are fine, but it would be great it you could remove this API change from the PR :)
Turbo87
force-pushed
the
version-authors-user-id
branch
from
b7c3209
to
1824cd6
Compare
|
I've rebased this and removed the commit that modified the API response. This should be good to go now. r? @jtgeibel |
|
Thanks for the PR @JohnTitor and for the rebase @Turbo87. I've confirmed on staging and production that @bors r+ |
|
📌 Commit 1824cd6 has been approved by |
|
☀️ Test successful - checks-actions |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2056
r? @carols10cents