Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add more CSS colors variables #2589

Closed
wants to merge 5 commits into from
Closed

Add more CSS colors variables #2589

wants to merge 5 commits into from

Conversation

Turbo87
Copy link
Member

@Turbo87 Turbo87 commented Jun 18, 2020

Following the suggestions in https://refactoringui.com/book/, I have

  • converted all color definitions in our CSS files to use HSL instead of RGB and Hex
  • added more variants of the existing main colors
  • added a visual regression test for the color palette

Bildschirmfoto 2020-06-18 um 09 54 29

Currently in use are --grey900, --yellow500, --green800 and --violet800.

r? @locks

@Turbo87 Turbo87 added A-frontend 🐹 C-internal 🔧 Category: Nonessential work that would make the codebase more consistent or clear labels Jun 18, 2020
@bors
Copy link
Contributor

bors commented Jun 19, 2020

☔ The latest upstream changes (presumably #2590) made this pull request unmergeable. Please resolve the merge conflicts.

@Turbo87 Turbo87 closed this Sep 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@locks locks

Labels
A-frontend 🐹 C-internal 🔧 Category: Nonessential work that would make the codebase more consistent or clear
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Turbo87 @bors @locks @rust-highfive