Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update oauth2 and remove failure dependency #2953

Closed
wants to merge 2 commits into from

Conversation

Turbo87
Copy link
Member

@Turbo87 Turbo87 commented Oct 23, 2020

This PR updates the oauth2 dependency to the latest v4 pre-release (see ramosbugs/oauth2-rs#99). This allows us to finally get rid of the failure dependency, because oauth2 v3 was our last dependency using it.

r? @jtgeibel

@pietroalbini
Copy link
Member

r? @pietroalbini

I'm slightly worried about upgrading to a pre-release for a library related to authentication. Is there a reason for this other than just removing failure?

@Turbo87
Copy link
Member Author

Turbo87 commented Oct 27, 2020

I'm slightly worried about upgrading to a pre-release for a library related to authentication. Is there a reason for this other than just removing failure?

nope, that was my only reason. and I generally share your concern about the pre-release version. I looked at ramosbugs/oauth2-rs#99 and saw that the list of v4 was almost done though, and since the update was building fine and the test suite passing I was somewhat confident in this. we can also move this to WIP status though and wait for their final release.

@pietroalbini
Copy link
Member

Yeah let's wait until the final release.

@bors
Copy link
Contributor

bors commented Oct 31, 2020

☔ The latest upstream changes (presumably #2989) made this pull request unmergeable. Please resolve the merge conflicts.

Note that reviewers usually do not review pull requests until merge conflicts are resolved! Once you resolve the conflicts, you should change the labels applied by bors to indicate that your PR is ready for review. Post this as a comment to change the labels:

@rustbot modify labels: +S-waiting-on-review -S-waiting-on-author

@Turbo87
Copy link
Member Author

Turbo87 commented Oct 31, 2020

closing for now until a stable oauth2 release exists

@Turbo87 Turbo87 closed this Oct 31, 2020
@Turbo87 Turbo87 deleted the oauth-4 branch January 30, 2021 21:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants