Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing centered CSS class #2060

Merged
merged 1 commit into from Mar 7, 2023

Conversation

GuillaumeGomez
Copy link
Member

@GuillaumeGomez GuillaumeGomez commented Feb 26, 2023

Fixes cases like this (content is completely on the left, leaving big "empty space" on the right):

Screenshot from 2023-02-26 21-37-52

As a reminder, #1698 is still waiting for feedback to prevent regressions like this to happen. ;)

@github-actions github-actions bot added the S-waiting-on-review Status: This pull request has been implemented and needs to be reviewed label Feb 26, 2023
@Nemo157
Copy link
Member

Nemo157 commented Feb 27, 2023

These pages being left-aligned was an explicit change #2012

@GuillaumeGomez
Copy link
Member Author

Even the search results and the non "main" crate pages?

@Nemo157
Copy link
Member

Nemo157 commented Feb 27, 2023

The docs.rs crate pages, yes that was definitely called out in the PR, and the search page is one of the "release pages".

@Nemo157
Copy link
Member

Nemo157 commented Feb 27, 2023

(Pages that looks like they could do with a bit of style work to make left-alignment look better are https://docs.rs/crate/serde/1.0.152/builds and https://docs.rs/crate/serde/1.0.152/builds/709459, those are the only ones without a left-sidebar).

@GuillaumeGomez
Copy link
Member Author

Okay, gonna update the PR then.

@GuillaumeGomez
Copy link
Member Author

Put back the left align like mentioned.

@Nemo157
Copy link
Member

Nemo157 commented Mar 2, 2023

cc @jsha since you have more context on what the overall plan of left aligning was.

Copy link
Contributor

@jsha jsha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me. The idea with left-aligning is that the rustdoc pages themselves are left-aligned, and the crate pages are related to them, so it's jarring to go back and forth between left-aligned and right-aligned.

For the homepage and various pages that show search results, it's reasonable to be centered, IMO.

In this PR, builds and build_details should ideally be left-aligned, but given that their layout is currently messed up when left-aligned I'm fine landing this as a quick fix. We should later follow up and left-align them with appropriate padding.

@GuillaumeGomez
Copy link
Member Author

Ok, merging then. Thanks for the feedback!

@GuillaumeGomez GuillaumeGomez merged commit f4b080f into rust-lang:master Mar 7, 2023
@GuillaumeGomez GuillaumeGomez deleted the missing-centered branch March 7, 2023 23:24
@github-actions github-actions bot added S-waiting-on-deploy This PR is ready to be merged, but is waiting for an admin to have time to deploy it and removed S-waiting-on-review Status: This pull request has been implemented and needs to be reviewed labels Mar 7, 2023
@syphar syphar removed the S-waiting-on-deploy This PR is ready to be merged, but is waiting for an admin to have time to deploy it label Mar 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants