convert ena to no-std
#48
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Noratrieb
reviewed
Jun 5, 2023
src/undo_log.rs
Outdated
Comment on lines
187
to
188
| #[cfg(feature = "log")] | ||
| debug!("rollback_to({})", snapshot.undo_len); |
There was a problem hiding this comment.
could you add a custom debug macro that does the cfg?
like
macro_rules! debug {
($($tt:tt)*) => {
#[cfg(feature = "log")]
log::debug!($($tt)*);
};
}}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #47 and converts ena to be no-std compatible.
I have taken the liberty also to make
logoptional (as some crates may prefer to usetracingor another solution) and removing thebitvec.rsfile (addressing #18).I have run the crate through
cargo-hackto verify that all feature permutations work as expected.The `cargo-hack` command used
cargo hack --optional-deps --feature-powerset nextest run