Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Some doc tests fail with ICE #1657

Closed
taiki-e opened this issue Jun 6, 2019 · 3 comments · Fixed by #1685
Closed

Some doc tests fail with ICE #1657

taiki-e opened this issue Jun 6, 2019 · 3 comments · Fixed by #1685

Comments

@taiki-e
Copy link
Member

taiki-e commented Jun 6, 2019

#1656 (comment)
@taiki-e
Copy link
Member Author

taiki-e commented Jun 6, 2019 •
edited
Loading

I think it is good to temporarily ignore these tests and revert them after rust-lang/rust#61442 rust-lang/rust#61579 fixes.

@taiki-e taiki-e mentioned this issue Jun 6, 2019
Merged
@Nemo157
Copy link
Member

Nemo157 commented Jun 6, 2019

Tests passed on rustc 1.37.0-nightly (5d8f59f4b 2019-06-04) and failed on rustc 1.37.0-nightly (7cdaffd79 2019-06-05), that's means they worked after the version where rust-lang/rust#61442 failed so likely a different issue (also, 61442 seems to be related to the Assign* operators and blocks, whereas at a guess from looking at the error message + failing tests this is somehow related to changes in implicit-drop/StorageDead handling in generators).

@Nemo157
Copy link
Member

Nemo157 commented Jun 6, 2019

Minimal repro. I'll open a new rust-lang/rust ticket about it.

@Nemo157 Nemo157 mentioned this issue Jun 6, 2019
Closed
@taiki-e taiki-e mentioned this issue Jun 6, 2019
Merged
@taiki-e taiki-e mentioned this issue Jun 26, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Revert "Ignore doc tests which "Broken MIR" ICE occurred" taiki-e/futures-rs
2 participants
@Nemo157 @taiki-e